✨(website) dashboard video #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
changed the base branch from
master
to
feature/anthony/website/create-video
AntoLC
force-pushed
the
feature/anthony/website/create-video
branch
from
fbecb9f
to
d5c8e33
Compare
AntoLC
force-pushed
the
feature/anthony/website/update-video
branch
2 times, most recently
from
5f517a9
to
48358bd
Compare
AntoLC
force-pushed
the
feature/anthony/website/create-video
branch
from
d5c8e33
to
0297445
Compare
Base automatically changed from
feature/anthony/website/create-video
to
master
February 27, 2023 11:36
AntoLC
force-pushed
the
feature/anthony/website/update-video
branch
from
48358bd
to
389daae
Compare
AntoLC
force-pushed
the
feature/anthony/website/update-video
branch
6 times, most recently
from
9f0a4fb
to
2f64673
Compare
kernicPanel
approved these changes
Mar 2, 2023
Comment on lines
37
to
38
| columns = columns > 3 ? 3 : columns; | ||
| setNbrOfColumns(columns || 1); |
There was a problem hiding this comment.
Maybe we could extract those values to conf/global.ts ?
Something like MAX_WIDGETS_COLUMNS and MIN_WIDGETS_COLUMNS ?
There was a problem hiding this comment.
I added some globals to be cleaner.
9226d81
I don't know about conf/global.ts, if it is used only in this module IMO I would rather let it inside the module. However if it is used in other modules, yes it would make sense to add them in conf/global.ts .
| {mapper.map((_, indexColumn) => ( | ||
| <Box | ||
| direction="column" | ||
| key={indexColumn} | ||
| width={`${100 / nbrOfColumns}%`} | ||
| width={{ | ||
| max: '600px', |
There was a problem hiding this comment.
Same here with MAX_WIDGETS_COLUMN_SIZE ?
Comment on lines
-246
to
-247
| INVITE: { | ||
| path: `/my-contents/videos/:videoId/invite/:inviteId`, | ||
| }, |
There was a problem hiding this comment.
Should this be just deleted ?
There was a problem hiding this comment.
Apparently for the moment we will not use invitation link for the video.
AntoLC
force-pushed
the
feature/anthony/website/update-video
branch
from
2f64673
to
fe44120
Compare
This was
linked to
issues
Mar 3, 2023
AntoLC
force-pushed
the
feature/anthony/website/update-video
branch
from
fe44120
to
015c596
Compare
AntoLC
requested review from
lunika and
kernicPanel
and removed request for
lunika and
kernicPanel
lunika
approved these changes
Mar 7, 2023
|
|
||
| const messages = defineMessages({ | ||
| 404: { | ||
| defaultMessage: "We didn't find the video you were looking for.", |
There was a problem hiding this comment.
Suggested change
| defaultMessage: "We didn't find the video you were looking for.", | |
| defaultMessage: "We don't find the video you are looking for.", |
Add my-playlist/create as sub route of my-playlist, by making it a sub route the menu stays highlighted when we are on the create modal.
- Changes prop itemsLength to hasResult to be more generic - Add a new prop `error` to customize the error message - expose ManageAPIState from Contents
Globalize conf react_query call api to avoid to repeat the same conf for each call api.
Update the columns number depend the size of the parent container.
- migrate lti_site/components/DashboardVideoWrapper to lib-video - adapt import in LTI project
Renamed LTIUploadHandlers to UploadHandlers to be more generic, it will be used in the standalone site too.
- integrate video dashboard in the website - adapt getOrInitAnonymousId to work with website token
A mock to the thumbnails api call was missing in the VideoWidgetProvider test. This commit adds it.
The license label was not correct. We changed to a correct one.
The websocket was targeting the wrong url in local(port 3000). We had to proxy it to the backend.
When a video is uploaded on our website, we automatically generate a thumbnail for it. We can also manually select a thumbnail for a video. If a video has both an automated and a manual thumbnail, we want to prioritize the manual one and display it in the related video component.
Add a filter to the api to get only live video or only video on demand.
When a list of video is serialized, the first one having a thumbnail stores ths thumbnail instance in a serializer property. This property is never reset and the consequence is that this thumbnail instance will be used by the next video instance serialized. To fix the issue, we must force to set the thmubnail_instance to None at the beginning of the to_representation method.
To be able to manage the video states between our apps, we created useSetVideoState hook. In LTI app some states video are only for one resource, but on the website a lot of resources cohabit, so we have to reset the state when we switch between resources.
When a user uploads a thumbnail, we display a progress to inform him about the upload status.
Before that the video id was determined from the token, but in the website the token doesn't have this information. So we need to pass it explicitly to the API.
- When a thumbnail was uploaded multiple times, the thumbnail status was not reset correctly, causing an early resetUpload, the thumbnail message status had problem because of that as well. - The poster video was not updated correctly when the thumbnail was uploaded multiple times.
Display the video menu item and the video in the Contents component.
Before that the video id was determined from the token, but in the website the token doesn't have this information. So we need to pass it explicitly to the API.
Before that the video id was determined from the token, but in the website the token doesn't have this information. So we need to pass it explicitly to the API.
- When a video was uploaded multiple times, the upload status was reset too early, causing sometime an error 500.
AntoLC
force-pushed
the
feature/anthony/website/update-video
branch
from
d1ce201
to
50294ab
Compare
lunika
added a commit
that referenced
this pull request
Apr 19, 2023
Added - standalone website: - Integrate VOD dashboard (#2086) - List the lives in the contents section (#2104) - Live session model - Livesession backend rewrite - Add sentry - Create a live from the website (#2134) - Integrate webinar dashboard (#2135) - Add a License Manager widget for LTI VOD view - Add a title to the classroom file dropzone - Add can_edit property on a serialized video - Add an attribute to consumer site to deactivate resources in LTI select - live transpilation on lib-video (#2150) - live transpilation on lib-classroom (#2157) - live transpilation on lib-markdown (#2160) - live transpilation on lib-components (#2161) - live transpilation on lib-tests (#2163) - live transpilation on lib-common (#2164) - Add a widget provider for the classroom creation form - Allow delete playlist resources - FileDepository - Classroom - Document - Markdown - Allow delete playlist - add routes related URL: - thumbnails - timed_text_track - shared_live_media - Add classroom widgets : - InfoBar - Description - Scheduling - Invite links - Support sharing - Recordings - Add classroom invite link for an instructor - Add a "Tools & Applications" widget for classrooms Changed - Update live sessions API to use nested video ID route - Move generic widget components from lib-video to lib-components - Make video dashboard collapsed by default - improve the dropdown languages positionning in the dashboard (#2138) - Make video dashboard visible by default, and collapsed when using the Moodle atto plugin - Update live_session api to use mixin to prevent url crafting - standalone website: - put the creating ressource form submit button disabled when the form is invalid (#2175) Fixed - redirect to error page when VOD is deleted - Manage disconnection when multiple tabs were open on standalone site - synchronisation between pages for the VOD description widget - tooltip position on the website context dashboard (#2136) - thumbnail not reset correctly on the video player (#2137) - display title / description when a classroom is not scheduled and not started - correctly fetch transcript content in TranscriptReader - remove unused 'initiate-live' permissions - increase debounce time in classroom description widget - remove id3 tags upload when live channel is not ready - add an invitation link for moderators in a launched classroom if available
lunika
added a commit
that referenced
this pull request
Apr 19, 2023
Added - standalone website: - Integrate VOD dashboard (#2086) - List the lives in the contents section (#2104) - Live session model - Livesession backend rewrite - Add sentry - Create a live from the website (#2134) - Integrate webinar dashboard (#2135) - Add a License Manager widget for LTI VOD view - Add a title to the classroom file dropzone - Add can_edit property on a serialized video - Add an attribute to consumer site to deactivate resources in LTI select - live transpilation on lib-video (#2150) - live transpilation on lib-classroom (#2157) - live transpilation on lib-markdown (#2160) - live transpilation on lib-components (#2161) - live transpilation on lib-tests (#2163) - live transpilation on lib-common (#2164) - Add a widget provider for the classroom creation form - Allow delete playlist resources - FileDepository - Classroom - Document - Markdown - Allow delete playlist - add routes related URL: - thumbnails - timed_text_track - shared_live_media - Add classroom widgets : - InfoBar - Description - Scheduling - Invite links - Support sharing - Recordings - Add classroom invite link for an instructor - Add a "Tools & Applications" widget for classrooms Changed - Update live sessions API to use nested video ID route - Move generic widget components from lib-video to lib-components - Make video dashboard collapsed by default - improve the dropdown languages positionning in the dashboard (#2138) - Make video dashboard visible by default, and collapsed when using the Moodle atto plugin - Update live_session api to use mixin to prevent url crafting - standalone website: - put the creating ressource form submit button disabled when the form is invalid (#2175) Fixed - redirect to error page when VOD is deleted - Manage disconnection when multiple tabs were open on standalone site - synchronisation between pages for the VOD description widget - tooltip position on the website context dashboard (#2136) - thumbnail not reset correctly on the video player (#2137) - display title / description when a classroom is not scheduled and not started - correctly fetch transcript content in TranscriptReader - remove unused 'initiate-live' permissions - increase debounce time in classroom description widget - remove id3 tags upload when live channel is not ready - add an invitation link for moderators in a launched classroom if available
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Integrate the dashboard video in the standalone website.
Proposal
dashboard.webm