Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️(frontend) lib-tests live transpiling #2163

Merged
merged 8 commits into from
Apr 3, 2023
Merged

⚡️(frontend) lib-tests live transpiling #2163

merged 8 commits into from
Apr 3, 2023

Conversation

AntoLC
Copy link
Contributor

@AntoLC AntoLC commented Mar 31, 2023

Purpose

Improve development process by not having to rebuild our packages after a change.
We will listen our packages from our applications and transpile automatically when a change happen.

Proposal

  • adapt lib_tests with the new setup
  • remove rollup from lib_tests
  • plug lib_tests to apps and packages

@AntoLC AntoLC self-assigned this Mar 31, 2023
@AntoLC AntoLC force-pushed the feature/anthony/lib-tests/transpile-on-the-fly branch 3 times, most recently from 239cfcd to 06e7e48 Compare March 31, 2023 12:35
@AntoLC AntoLC marked this pull request as ready for review March 31, 2023 12:35
@AntoLC AntoLC force-pushed the feature/anthony/lib-tests/transpile-on-the-fly branch 6 times, most recently from 5e7a339 to 5ae3ab2 Compare April 3, 2023 08:01
kernicPanel
kernicPanel approved these changes Apr 3, 2023
View reviewed changes
src/frontend/apps/lti_site/components/App/AppInitializer/index.tsx
@@ -64,7 +64,7 @@ export const AppInitializer = (
release: appConfig.release,
});
Sentry.configureScope((scope) =>
scope.setExtra('application', 'standalone'),
scope.setExtra('application', 'frontend'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@AntoLC AntoLC force-pushed the feature/anthony/lib-tests/transpile-on-the-fly branch from 5ae3ab2 to e6b1244 Compare April 3, 2023 08:33
@AntoLC AntoLC enabled auto-merge (rebase) April 3, 2023 08:34
@AntoLC AntoLC force-pushed the feature/anthony/lib-tests/transpile-on-the-fly branch from e6b1244 to 70fcd6b Compare April 3, 2023 08:50
@AntoLC
🔧(marsha-config) packages dependencies in config
c7a4709 
Help to generate the `moduleNameMapper` for `jest.config.js` based
on the dependencies of the marsha-config package.
@AntoLC
📌(lib-components) update yarn.lock after removing rollup
b1c5222 
- The yarn.lock file was not updated after removing rollup from the
dependencies of the lib-components package. This commit updates the
yarn.lock file.
- re-install babel-plugin-formatjs, it is necessary for the tests
@AntoLC
➕(frontend) add lib-tests to packages and apps
75691f4 
Add lib-tests to packages and apps with the transpiling on the fly.
@AntoLC
🚚(frontend) fix relative import with @lib-tests
08fe558 
By including lib-tests in the apps and packages, we got relative
imports problems coming from lib-tests, it is because the
relative import are from the apps perspective.
This commit fixes this issue by using the `@lib-tests` alias.
@AntoLC
🔥(lib-tests) remove rollup from lib_tests
f012cdf 
We don't need to build lib_tests anymore, it is transpile during
the apps build.
- review dependencies packages about lib_tests
- 🔥 all build relative dependencies from lib_tests
- 🔥 rollup.config.mjs from lib_tests
- adapt CI config and frontend package
@AntoLC
📌(frontend) pin packages to current version
0ba06d8 
To pin our packages with * seems to create issues with yarn.
It could be because of the keyword "-beta":
@see yarnpkg/yarn#6079
@AntoLC
🐛(website) fix CI sentry out of memory error
46da7ce 
The library `Sentry` seems quite big, circle jobs building
the standalone_site get sometimes out of memories.
- We fixed the problem by adding more memory to the jobs.
- The scope was not correct on LTI, we changed it.
@AntoLC
⚡️(makefile) add new packages to clean-front-modules
34d46bd 
We created new packages, we need to clean them as well
when we run the command clean-front-modules.
@AntoLC AntoLC force-pushed the feature/anthony/lib-tests/transpile-on-the-fly branch from 70fcd6b to 34d46bd Compare April 3, 2023 08:51
@AntoLC AntoLC merged commit 6748cea into master Apr 3, 2023
@AntoLC AntoLC deleted the feature/anthony/lib-tests/transpile-on-the-fly branch April 3, 2023 09:04
lunika added a commit that referenced this pull request Apr 19, 2023
@lunika
🔖(beta) bump release to 4.0.0-beta.19
8f8b135 
Added

- standalone website:
  - Integrate VOD dashboard (#2086)
  - List the lives in the contents section (#2104)
  - Live session model
  - Livesession backend rewrite
  - Add sentry
  - Create a live from the website (#2134)
  - Integrate webinar dashboard (#2135)
- Add a License Manager widget for LTI VOD view
- Add a title to the classroom file dropzone
- Add can_edit property on a serialized video
- Add an attribute to consumer site to deactivate resources in LTI select
- live transpilation on lib-video (#2150)
- live transpilation on lib-classroom (#2157)
- live transpilation on lib-markdown (#2160)
- live transpilation on lib-components (#2161)
- live transpilation on lib-tests (#2163)
- live transpilation on lib-common (#2164)
- Add a widget provider for the classroom creation form
- Allow delete playlist resources
  - FileDepository
  - Classroom
  - Document
  - Markdown
- Allow delete playlist
- add routes related URL:
  - thumbnails
  - timed_text_track
  - shared_live_media
- Add classroom widgets :
  - InfoBar
  - Description
  - Scheduling
  - Invite links
  - Support sharing
  - Recordings
- Add classroom invite link for an instructor
- Add a "Tools & Applications" widget for classrooms

Changed

- Update live sessions API to use nested video ID route
- Move generic widget components from lib-video to lib-components
- Make video dashboard collapsed by default
- improve the dropdown languages positionning in the dashboard (#2138)
- Make video dashboard visible by default, and collapsed when using the
  Moodle atto plugin
- Update live_session api to use mixin to prevent url crafting
- standalone website:
  - put the creating ressource form submit button disabled when the
    form is invalid (#2175)

Fixed

- redirect to error page when VOD is deleted
- Manage disconnection when multiple tabs were open on standalone site
- synchronisation between pages for the VOD description widget
- tooltip position on the website context dashboard (#2136)
- thumbnail not reset correctly on the video player (#2137)
- display title / description when a classroom is not scheduled and not started
- correctly fetch transcript content in TranscriptReader
- remove unused 'initiate-live' permissions
- increase debounce time in classroom description widget
- remove id3 tags upload when live channel is not ready
- add an invitation link for moderators in a launched classroom if available
@lunika lunika mentioned this pull request Apr 19, 2023
Merged
lunika added a commit that referenced this pull request Apr 19, 2023
@lunika
🔖(beta) bump release to 4.0.0-beta.19
fe19f71 
Added

- standalone website:
  - Integrate VOD dashboard (#2086)
  - List the lives in the contents section (#2104)
  - Live session model
  - Livesession backend rewrite
  - Add sentry
  - Create a live from the website (#2134)
  - Integrate webinar dashboard (#2135)
- Add a License Manager widget for LTI VOD view
- Add a title to the classroom file dropzone
- Add can_edit property on a serialized video
- Add an attribute to consumer site to deactivate resources in LTI select
- live transpilation on lib-video (#2150)
- live transpilation on lib-classroom (#2157)
- live transpilation on lib-markdown (#2160)
- live transpilation on lib-components (#2161)
- live transpilation on lib-tests (#2163)
- live transpilation on lib-common (#2164)
- Add a widget provider for the classroom creation form
- Allow delete playlist resources
  - FileDepository
  - Classroom
  - Document
  - Markdown
- Allow delete playlist
- add routes related URL:
  - thumbnails
  - timed_text_track
  - shared_live_media
- Add classroom widgets :
  - InfoBar
  - Description
  - Scheduling
  - Invite links
  - Support sharing
  - Recordings
- Add classroom invite link for an instructor
- Add a "Tools & Applications" widget for classrooms

Changed

- Update live sessions API to use nested video ID route
- Move generic widget components from lib-video to lib-components
- Make video dashboard collapsed by default
- improve the dropdown languages positionning in the dashboard (#2138)
- Make video dashboard visible by default, and collapsed when using the
  Moodle atto plugin
- Update live_session api to use mixin to prevent url crafting
- standalone website:
  - put the creating ressource form submit button disabled when the
    form is invalid (#2175)

Fixed

- redirect to error page when VOD is deleted
- Manage disconnection when multiple tabs were open on standalone site
- synchronisation between pages for the VOD description widget
- tooltip position on the website context dashboard (#2136)
- thumbnail not reset correctly on the video player (#2137)
- display title / description when a classroom is not scheduled and not started
- correctly fetch transcript content in TranscriptReader
- remove unused 'initiate-live' permissions
- increase debounce time in classroom description widget
- remove id3 tags upload when live channel is not ready
- add an invitation link for moderators in a launched classroom if available
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kernicPanel kernicPanel kernicPanel approved these changes

@lunika lunika lunika approved these changes

Assignees

@AntoLC AntoLC

Labels
Frontend improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AntoLC @kernicPanel @lunika