♻️(frontend) replace grommet DropButton with custom DropButton #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
refacto/anthony/grommet-select-dropButton
branch
3 times, most recently
from
b889744
to
822b37d
Compare
We replace the grommet Select components by the cunningham Select components.
The footer was stepping on the login form on some devices. This commit fixes that.
AntoLC
force-pushed
the
refacto/anthony/grommet-select-dropButton
branch
from
822b37d
to
a5f417d
Compare
In order to do the transition to the cunningham design system, we replace the grommet DropButton component with a custom DropButton components based on the Popover cunningham component.
AntoLC
force-pushed
the
refacto/anthony/grommet-select-dropButton
branch
from
a5f417d
to
cef0862
Compare
lunika
approved these changes
Nov 27, 2023
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
lunika
added a commit
that referenced
this pull request
Nov 29, 2023
Added - Meta description and meta title on the website from the API (#2516) - Retrieve BBB learning analytics and send them through API - Classroom attendance analytics (#2499) - Add a language picker for the invite link on the website (#2504) Changed - Replace grommet DropButton component (#2513) - On live, can now share resource when one is already shared (#2512) - Remove persistency on token from invite link (#2505) - Replace grommet Cards / Footer/ Anchor / Tip / Nav (#2503) - Refacto widgets SharedLiveMedia (#2504) - Replace grommet Button (#2453) - Replace grommet Box (#2484) - Replace grommet TextArea (#2500) - Update psycopg to version 3 - Update node to version 20 - Replace pylti with oauthlib for LTI request validation - Replace faker with @faker-js/faker (frontend) Fixed - Blocking error when shared document is deleted (#2504) - Improve render sharing picture in live (#2508)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In order to do the transition to the cunningham design system,
we replace the grommet
DropButtoncomponent with a customDropButtoncomponents based on the Popover cunningham component.Proposal
Visual change
Dropdown white, icon blue
Remove the footer wave on small device on login page