🐛(frontend) wrong store with invite link #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
issue/anthony/wrong-jwt-store
branch
2 times, most recently
from
c5b7667
to
e96acb7
Compare
lunika
approved these changes
Nov 30, 2023
The API calls were still using the persistent store instead of the local store when using the invite link. We removed these double stores and now only use 1 store that have a "withPersistency" option. The invite links set this option to false so that the store is not persistent.
AntoLC
force-pushed
the
issue/anthony/wrong-jwt-store
branch
from
e96acb7
to
28844e1
Compare
lunika
added a commit
that referenced
this pull request
Nov 30, 2023
Fixed - Fix invite links on BBB (#2521)
lunika
added a commit
that referenced
this pull request
Nov 30, 2023
Fixed - Fix invite links on BBB (#2521)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The API calls were still using the persistent store instead of the local store when using the invite link.
Proposal
We removed these double stores logic and now only use 1 store that have a "withPersistency" option.
The invite links set this option to false so that the store is not persistent.