Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve teachers teams UX #58

Merged
merged 4 commits into from
May 18, 2022
Merged

Improve teachers teams UX #58

merged 4 commits into from
May 18, 2022

Conversation

quitterie-lcs
Copy link
Member

@quitterie-lcs quitterie-lcs commented May 5, 2022

Purpose

Some details needed to be improved for users experience.

Proposal

  • set default theme to light
  • predefine dashboard uids/remove post deployement hooks
  • add home page for teacher team

@quitterie-lcs quitterie-lcs changed the title 💄(grafana) change default theme to light Improve teachers teams UX May 5, 2022
@quitterie-lcs quitterie-lcs force-pushed the set-teachers-preferences branch 3 times, most recently from e7b4744 to 18009a1 Compare May 6, 2022 15:11
@quitterie-lcs quitterie-lcs marked this pull request as ready for review May 6, 2022 15:13
@quitterie-lcs quitterie-lcs self-assigned this May 6, 2022
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you must remove the post-deploy hook script but restore the hooks feature.

@quitterie-lcs quitterie-lcs force-pushed the set-teachers-preferences branch 2 times, most recently from fae1a6e to c4cbb4f Compare May 13, 2022 14:06
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I suggest few interface improvements 💪

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
src/dashboards/teachers/home.jsonnet Outdated Show resolved Hide resolved
src/dashboards/teachers/home.jsonnet Outdated Show resolved Hide resolved
src/dashboards/teachers/home.jsonnet Outdated Show resolved Hide resolved
src/dashboards/teachers/home.jsonnet Show resolved Hide resolved
src/dashboards/common.libsonnet Outdated Show resolved Hide resolved
Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By default, the change theme is set to dark. But for random users, the
default theme has to be set to light.
Dashboards uids can be defined manually in the provisioning.
The post-deployment hook is no longer useful in the project as dashboard
uids for table link are predefined.
When teachers log in on Grafana, the home page is not welcoming as it is
the default home page for Grafana. A page with a dashboard list composes
the new home page.
Post deployment hook is no longer useful as the dashboard uids can be
manually defined in the provisioning.
@quitterie-lcs quitterie-lcs merged commit ff1eccf into main May 18, 2022
@quitterie-lcs quitterie-lcs deleted the set-teachers-preferences branch May 18, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants