Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tray: add LRS server #217

Merged
merged 7 commits into from
Oct 18, 2022
Merged

Tray: add LRS server #217

merged 7 commits into from
Oct 18, 2022

Conversation

jmaupetit
Copy link
Contributor

@jmaupetit jmaupetit commented Sep 30, 2022 •
edited
Loading

Purpose

Add support to run Ralph's LRS server on k8s.

Proposal

  • add database status checking
  • add health router
  • start the LRS server as the default command
  • add LRS server support
  • add k8s-related helpers
  • use k8s-related helpers in the CI

@jmaupetit
✨(backends) add database status checking
fc307b6 
In a LRS context, it's useful to test database status (connection and
cluster health).
@jmaupetit
✨(api) add health router
f3536a0 
We need a way to check LRS status (load balancing + server checks). For
now we only check database connexion.
@jmaupetit
🔧(project) start the LRS server as the default command
128019a 
The `app` docker-compose service now runs the LRS server by default.
We've added a Makefile rule to ease LRS boostraping.
@jmaupetit
✨(tray) add LRS server support
b776db8 
Ralph also is a LRS, we need more objects to deploy such server in a k8s
context.
@jmaupetit jmaupetit force-pushed the tray-add-server branch 3 times, most recently from 8a30061 to 1aedb29 Compare October 11, 2022 10:28
@jmaupetit jmaupetit self-assigned this Oct 11, 2022
@jmaupetit jmaupetit marked this pull request as ready for review October 11, 2022 10:29
@jmaupetit jmaupetit mentioned this pull request Oct 11, 2022
Merged
@jmaupetit jmaupetit requested a review from lunika October 12, 2022 07:39
lunika
lunika reviewed Oct 12, 2022
View reviewed changes
docs/contribute.md Outdated Show resolved Hide resolved
quitterie-lcs
quitterie-lcs reviewed Oct 12, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
SergioSim
SergioSim reviewed Oct 17, 2022
View reviewed changes
Copy link
Collaborator

@SergioSim SergioSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Great)
Sorry for the long delay, I'm unfortunately still not able to fully follow the setup process because my machine doesn't have enough storage for now(

docs/contribute.md Outdated Show resolved Hide resolved
Makefile
Comment on lines +26 to +27
ARNOLD_CUSTOMER ?= ralph
ARNOLD_ENVIRONMENT ?= development
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As these values might be redefined using environment variables, should we add a RALPH_ prefix?
Or are these environment variables intended to be shared between multiple applications?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my point of view, those are defined locally on a project basis, hence I don't expect them to be defined globally.

docs/contribute.md
bootstrapping should be run _via_:

```bash
$ make k3d-cluster
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, this command didn't work for me as I had an apache2 server running on ports 80 & 443. It might be helpful to know that this command expects these ports to be available on the host machine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a remark for this.

docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
quitterie-lcs
quitterie-lcs reviewed Oct 17, 2022
View reviewed changes
docs/contribute.md Outdated Show resolved Hide resolved
@jmaupetit
Copy link
Contributor Author

@SergioSim & @quitterie-lcs I've addressed all your comments, ready for another review! 🙏

jmaupetit
jmaupetit commented Oct 18, 2022
View reviewed changes
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
quitterie-lcs
quitterie-lcs reviewed Oct 18, 2022
View reviewed changes
docs/contribute.md Outdated Show resolved Hide resolved
@jmaupetit
✨(project) add k3d utils for tray development
4215885 
Ralph should be self-contained, and helpers are required for
Kubernetes-related developments. We've added such helpers to:

1. run a local k3d cluster
2. run arnold commands
@jmaupetit
👷(circle) switch to Makefile rules
2fa2387 
Using Makefile rules to avoid repetition and automate rules testing
seemed a good idea!
@jmaupetit
👷(circle) update deprecated convenience images
c29eee3 
`buildpack-deps` images are now deprecated. Following CircleCI
recommendation, we've switched them to base convenience images.

References:

[1] https://discuss.circleci.com/t/legacy-convenience-image-deprecation/41034
[2] https://circleci.com/developer/images/image/cimg/base

gitlint-ignore: all
quitterie-lcs
quitterie-lcs approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@quitterie-lcs quitterie-lcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ! 🚀🚀

@jmaupetit jmaupetit merged commit 6be9a8a into master Oct 18, 2022
@jmaupetit jmaupetit deleted the tray-add-server branch October 18, 2022 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunika lunika lunika approved these changes

@quitterie-lcs quitterie-lcs quitterie-lcs approved these changes

@SergioSim SergioSim Awaiting requested review from SergioSim

Assignees

@jmaupetit jmaupetit

Labels
feature needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jmaupetit @lunika @SergioSim @quitterie-lcs