📦️(project) improve dependencies management #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
force-pushed
the
split-dependencies
branch
from
a3d7cf7
to
e54e5a4
Compare
jmaupetit
force-pushed
the
split-dependencies
branch
2 times, most recently
from
284d9b6
to
440908b
Compare
jmaupetit
force-pushed
the
split-dependencies
branch
from
440908b
to
c7d9937
Compare
|
Ready for a new review! 🙏 |
sampaccoud
reviewed
Oct 19, 2022
sampaccoud
approved these changes
Oct 19, 2022
Ralph can be used as a CLI, as a server, or as a library. To handle this complexity, we decided to split dependencies to core and extra requirements: - the core package only contains dependencies to use Ralph as a library (mostly to use models in a python project), - the `cli` extra installs Click-related dependencies, - the `backends` extra installs all supported backends; it might also correspond to a library usage, - the `lrs` extra installs FastAPI-related dependencies for the LRS server implementation. A full installation command would look like: ``` pip install ralph-malph[backends,cli,lrs] ``` While a library installation could be: ``` pip install ralph-malph ``` or ``` pip install ralph-malph[backends] ```
jmaupetit
force-pushed
the
split-dependencies
branch
from
cf8882f
to
c0a31ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Ralph can be used as a CLI, as a server, or as a library. To handle this complexity, we need to split dependencies.
Proposal
We decided to split dependencies to core and extra requirements:
cliextra installs Click-related dependencies,backendsextra installs all supported backends; it might also correspond to a library usage,lrsextra installs FastAPI-related dependencies for the LRS server implementation.A full installation command would look like:
While a library installation could be:
or
Depends on #217 for the Tray testing in the CI.