馃摑(website) document the frontend build for dependents #887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbenadda
added
needs review
needs help
docs website
lunika
reviewed
Nov 12, 2019
| @@ -5,7 +5,7 @@ | |||
| "docker-development", | |||
| "native-installation" | |||
| ], | |||
| "Recipes": ["django-react-interop"], | |||
| "Recipes": ["django-react-interop", "building-the-frontend"], | |||
There was a problem hiding this comment.
we should maybe start a multi-line array ?
There was a problem hiding this comment.
That's prettier's job 馃槆
There was a problem hiding this comment.
I'm not sure the CI runs prettier in the website directory.
There was a problem hiding this comment.
Indeed, and we should probably add it. I was just saying in this instance I formatted with prettier and it does not put a newline here
mbenadda
force-pushed
the
document-client-build
branch
from
3fc04e3
to
b27ee7d
Compare
sampaccoud
approved these changes
Nov 12, 2019
Dependents can run their own build for CSS & JS to theme, modify or extend Richie. This was mostly not documented, be it in the repository or in the NPM package that we publish to facilitate it. We wrote some docs to help users figure out own to run it. They also explain the settings for the JS build.
mbenadda
force-pushed
the
document-client-build
branch
from
fefdc8a
to
4cdb42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Dependents can run their own build for CSS & JS to theme, modify or extend Richie. This was mostly not documented, be it in the repository or in the NPM package that we publish to facilitate it.
We wrote some docs to help users figure out own to run it. They also explain the settings for the JS build.
Note: this does not explain how to actually use the files when they are built, as I don't know how to do that 馃槄
Someone more qualified proabably needs to step in to complete this introduction