Run prettier on website dir #893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbenadda
added
needs review
docs website
lunika
reviewed
Nov 12, 2019
|
I don't think it's worth it as we don't have an image that operates on the website directory. This can probably be done if/when someone enables docker for the other website related tasks like building it, running it etc. |
We were not running prettier on the JS and JSON files in the website directory, and had no CI job to do that. This can cause ambiguity in formatting, which we resolved in the codebase by just running prettier. Add a CI job to lint the website dir with prettier.
We just added a prettier linting job for the website in our CI. To pass it in the first place, it's necessary to just run prettier in write mode over the directory.
mbenadda
force-pushed
the
run-prettier-on-website-dir
branch
from
f8a59f4
to
2213d0b
Compare
|
(I added a comment to this effect on #870) |
lunika
approved these changes
Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
We were not running prettier on the JS and JSON files in the website directory, and had no CI job to do that.
Proposal