⚡️(iframe) precalculate iframe height to improve user visual feeling #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmoch
force-pushed
the
anticipate-iframe-height
branch
from
92cad9f
to
7b7b373
Compare
rmoch
changed the title
sampaccoud
reviewed
Feb 7, 2019
configurable_lti_consumer/static/js/configurable_xblock_lti_consumer.js
Outdated
Show resolved
Hide resolved
configurable_lti_consumer/static/js/configurable_xblock_lti_consumer.js
Outdated
Show resolved
Hide resolved
configurable_lti_consumer/static/js/configurable_xblock_lti_consumer.js
Outdated
Show resolved
Hide resolved
rmoch
force-pushed
the
anticipate-iframe-height
branch
3 times, most recently
from
0b675d5
to
dfb85b1
Compare
sampaccoud
approved these changes
Feb 8, 2019
rmoch
force-pushed
the
anticipate-iframe-height
branch
from
b8866b3
to
7c1137b
Compare
|
@rmoch I proposed a fixup to really de-correlate the I tested it in all the following cases and it seems to work (would have written tests if there had been a test workbench. Let's do it in a separate PR 😃):
WDYT? |
sampaccoud
force-pushed
the
anticipate-iframe-height
branch
2 times, most recently
from
248c6e0
to
06efe97
Compare
As iframeResizer may take a few seconds to initialize and set correct iframe height, we calculate probable height regarding available width and configuration given ratio if available. We also use more comprehensive settings and drop deprecated XBlock.fragment library in favor of web_fragment.fragment
rmoch
force-pushed
the
anticipate-iframe-height
branch
from
06efe97
to
86dab5b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As iframeResizer may take a few seconds to initialize and set correct iframe
height, we calculate probable height regarding available width and configuration
given ratio. We also use more comprehensive settings and drop deprecated
XBlock.fragment library in favor of web_fragment.fragment