-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️(iframe) precalculate iframe height to improve user visual feeling #27
Conversation
92cad9f
to
7b7b373
Compare
configurable_lti_consumer/static/js/configurable_xblock_lti_consumer.js
Outdated
Show resolved
Hide resolved
configurable_lti_consumer/static/js/configurable_xblock_lti_consumer.js
Outdated
Show resolved
Hide resolved
configurable_lti_consumer/static/js/configurable_xblock_lti_consumer.js
Outdated
Show resolved
Hide resolved
0b675d5
to
dfb85b1
Compare
b8866b3
to
7c1137b
Compare
@rmoch I proposed a fixup to really de-correlate the I tested it in all the following cases and it seems to work (would have written tests if there had been a test workbench. Let's do it in a separate PR 😃):
WDYT? |
248c6e0
to
06efe97
Compare
As iframeResizer may take a few seconds to initialize and set correct iframe height, we calculate probable height regarding available width and configuration given ratio if available. We also use more comprehensive settings and drop deprecated XBlock.fragment library in favor of web_fragment.fragment
06efe97
to
86dab5b
Compare
As iframeResizer may take a few seconds to initialize and set correct iframe
height, we calculate probable height regarding available width and configuration
given ratio. We also use more comprehensive settings and drop deprecated
XBlock.fragment library in favor of web_fragment.fragment