New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use getattr instead of eval #207
Conversation
It seems |
Yeah it is, my bad. |
It is still failing. I am not sure if they are caused by the tests only or |
Yeah I'll look into it. It seems like trying to call |
This pull request fixes 3 alerts when merging 98d74ee into c28a48a - view on LGTM.com fixed alerts:
|
It is improving. Only |
Is there any reason why this:
would fail with |
This pull request fixes 3 alerts when merging 1b051a8 into d5d4248 - view on LGTM.com fixed alerts:
|
It should be import leafmap
import ipyleaflet
m = leafmap.Map()
in_csv = "https://raw.githubusercontent.com/giswqs/data/main/world/world_cities.csv"
m.add_circle_markers_from_xy(
in_csv, x="longitude", y="latitude", name="World Cities"
)
m.add_control(ipyleaflet.LayersControl(position="topright"))
m |
is the add_circle bug reproducable without the code in this pr? |
It is a bug of the ipyleaflet backend. Works fine with folium. |
This pull request fixes 3 alerts when merging 05b6daa into d5d4248 - view on LGTM.com fixed alerts:
|
Use getattr instead of eval Former-commit-id: 84ad70c
Former-commit-id: d5d6339
getattr
is more robust and cleaner than trying to use eval for getting parameters