Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improvement _get_dimension #844

Merged
merged 1 commit into from
Jul 23, 2024
Merged

chore: improvement _get_dimension #844

merged 1 commit into from
Jul 23, 2024

Conversation

slowy07
Copy link
Member

@slowy07 slowy07 commented Jul 22, 2024

improvement _get_dimension which

  • the conditional has been reversed to reduce nesting and to produce an error as soon as the orientation was wrong.
  • to prevent nested indexing, use tuple unpacking `(default_width, default_height)
  • to improve clarity, variable assignments have separated to ensure uniform and readability, the error message was written f-string format

@slowy07
chore: improvement _get_dimension
5921345 
Signed-off-by: slowy07 <slowy.arfy@proton.me>
@giswqs giswqs merged commit 9b29a89 into opengeos:master Jul 23, 2024
13 checks passed
@slowy07 slowy07 deleted the improvement-function branch July 23, 2024 01:16
kuzja111 pushed a commit to kuzja111/leafmap that referenced this pull request Jul 25, 2024
@slowy07
chore: improvement _get_dimension (opengeos#844)
5469aba 
Signed-off-by: slowy07 <slowy.arfy@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giswqs giswqs giswqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slowy07 @giswqs