Closes #112 #117
Merged
Closes #112 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstenger
requested changes
May 7, 2024
| @@ -48,17 +48,17 @@ public class CubeCollections extends AbstractFeatures { | |||
| CollectionsTime ct= new CollectionsTime(); | |||
| /** | |||
| * <pre> | |||
| * Abstract Test 70: Validate that the coords query parameters are constructed correctly. (cube) | |||
| * Abstract Test 70: Validate that the bbox query parameters are constructed correctly. (cube) | |||
There was a problem hiding this comment.
The standard (https://docs.ogc.org/is/19-086r4/19-086r4.html) still uses the old (wrong) sentence. I prefer it to leave it like that and to add a short comment explaining that the abstract test of the specification is wrong so that the test is implemented differently.
|
Also, do you have a test service to verify the fix? |
@dstenger You can test the fix with https://labs.metoffice.gov.uk/edr (and https://labs.metoffice.gov.uk/edr/api for API definition) |
dstenger
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #112