Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing #233 #255

Merged
merged 1 commit into from Mar 29, 2023
Merged

Closing #233 #255

merged 1 commit into from Mar 29, 2023

Conversation

bpross-52n
Copy link
Contributor

@bpross-52n bpross-52n commented Mar 2, 2023 •
edited

Closing #233

@bpross-52n bpross-52n changed the title Closing #223 Closing #233 Mar 2, 2023
@bpross-52n bpross-52n linked an issue Mar 2, 2023 that may be closed by this pull request
SR WFS Test - Reports invalid Geometry Operand #233
Closed
@dstenger dstenger self-requested a review March 17, 2023 16:34
@dstenger dstenger added this to the 1.40 milestone Mar 17, 2023
dstenger
dstenger reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@dstenger dstenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of pull request is blocked by #256.

@dstenger
Copy link
Contributor

It was possible to test the pull request with the workflow described in opengeospatial/teamengine#570 (comment).

dstenger
dstenger approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@dstenger dstenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several tests checking different combinations

  • Feature branches of teamengine and ets-wfs20
  • Feature branch of ets-wfs20 and teamengine v5.5.2
  • Feature branch of teamengine and ets-wfs20 without new feature branch

always led to the expected results.

@dstenger dstenger merged commit a128fda into master Mar 29, 2023
@dstenger dstenger mentioned this pull request Mar 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstenger dstenger dstenger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.

SR WFS Test - Reports invalid Geometry Operand
2 participants
@bpross-52n @dstenger