Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closing #555 #570

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Closing #555 #570

merged 1 commit into from
Mar 29, 2023

Conversation

bpross-52n
Copy link
Contributor

@bpross-52n bpross-52n commented Mar 2, 2023 •
edited by dstenger
Loading

Closes #555

@bpross-52n bpross-52n linked an issue Mar 2, 2023 that may be closed by this pull request
Wrong URL in HTML reports for test using POST requests #555
Closed
@bpross-52n
Copy link
Contributor Author

Successfully tested backwards compatibility with ets-wfs20.

@dstenger dstenger self-requested a review March 17, 2023 16:27
dstenger
dstenger reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@dstenger dstenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing is currently blocked by opengeospatial/ets-wfs20#256.

@dstenger dstenger added this to the 5.6 milestone Mar 17, 2023
@dstenger
Copy link
Contributor

I was able to test the pull request with following workflow:

  • Build feature branch issue#555 of teamengine
  • Set teamengine dependency to SNAPSHOT in ets-wfs20
  • Build feature branch issue#223-teamengine-560 of ets-wfs20
  • Set teamenengine and ets-wfs20 dependencies to SNAPSHOT in teamengine-docker
  • Build and start teameninge-beta of teamengine-docker

dstenger
dstenger approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@dstenger dstenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Several tests checking different combinations

  • Feature branches of teamengine and ets-wfs20
  • Feature branch of ets-wfs20 and teamengine v5.5.2
  • Feature branch of teamengine and ets-wfs20 without new feature branch

always led to the expected results.

@dstenger dstenger merged commit ef27095 into master Mar 29, 2023
@dstenger dstenger mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dstenger dstenger dstenger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.6
Development

Successfully merging this pull request may close these issues.

Wrong URL in HTML reports for test using POST requests
2 participants
@bpross-52n @dstenger