New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpkg_geometry_columns test needs to be updated #286

Closed
jyutzler opened this Issue Feb 9, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@jyutzler
Contributor

jyutzler commented Feb 9, 2017

The ATS for /opt/features/geometry_columns/data/table_def calls for an inspection of the table SQL. Better would be to inspect the table itself through a PRAGMA table_info('gpkg_geometry_columns') command as is done in /opt/features/vector_features/data/feature_table_integer_primary_key.

In addition the reference C.4Table 20 appears to be wrong. If anything it should be C.3 but really it should refer back to the table the requirement points to. However, Table 7 does not indicate that the columns may not be null. It needs to be updated too.

It appears that test /opt/features/geometry_columns/data/data_values_table_name (Requirement 23) is supposed to test for the foreign key relationships but that test is completely wrong (function name and table name are both incorrect and the test is incomprehensible) and needs to be rewritten.

@jyutzler jyutzler added this to the 1.2-comment period milestone Feb 14, 2017

jyutzler added a commit to jyutzler/geopackage that referenced this issue Feb 15, 2017

@jyutzler jyutzler referenced this issue Feb 15, 2017

Merged

fixing #286 #292

jyutzler added a commit that referenced this issue Feb 27, 2017

@jyutzler

This comment has been minimized.

Contributor

jyutzler commented Feb 27, 2017

PR Confirmed by the SWG today.

@jyutzler jyutzler closed this Feb 27, 2017

@jyutzler jyutzler reopened this Mar 3, 2017

@jyutzler jyutzler closed this Mar 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment