Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing requirement regarding lowercase identifiers? #603

Closed
heidivanparys opened this issue Jun 21, 2021 · 4 comments · Fixed by #604
Closed

Missing requirement regarding lowercase identifiers? #603

heidivanparys opened this issue Jun 21, 2021 · 4 comments · Fixed by #604
Labels
Administrative Change Requires a Corrigendum
Milestone

Comments

@heidivanparys
Copy link
Contributor

According to clause Base,

All specified table, view, column, trigger, and constraint name values SHALL be lowercase.

identifiers shall be lowercase. However, no separate, explicit, numbered requirement is present in the specification regarding this.

The line above that line also uses normative language, stating

All gpkg_* tables and views and all tiles user data tables specified in this standard SHALL have only the specified columns and table constraints. Any features user data tables MAY have columns in addition to those specified.

but those statements are enforced by requirements, such as e.g. requirement 10 and requirement 29.

And because there is no explicit requirement, no test is present in the ATS, and GeoPackage files using uppercase or camelcase identifiers can pass the test.

@heidivanparys
Copy link
Contributor Author

Note: some sample files in https://github.com/opengeospatial/geopackage/tree/gh-pages/data use uppercase identifiers, those should be updated as well if the statement regarding lowercase identifiers is actually a requirement.

@jyutzler
Copy link
Contributor

I think we agreed that we would specify all lowercase for identifiers specified in the standard, but that this constraint does not apply to user-defined identifiers. User-defined identifiers are easily discoverable and must be discovered to be used so this should not be an interoperability issue.

However, I would agree to some additional explanatory text. Any suggestions?

heidivanparys added a commit to heidivanparys/geopackage that referenced this issue Jun 22, 2021
@heidivanparys
Copy link
Contributor Author

However, I would agree to some additional explanatory text. Any suggestions?

See heidivanparys@9839fa2 for a suggestion.

@jyutzler
Copy link
Contributor

@heidivanparys The SWG concurs with this update. Please issue a pull request and we will accept it.

@jyutzler jyutzler added the Administrative Change Requires a Corrigendum label Jul 23, 2021
@jyutzler jyutzler added this to the 1.3.1 milestone Jul 23, 2021
jyutzler added a commit that referenced this issue Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Administrative Change Requires a Corrigendum
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants