Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crs data type: JSON object #128

Closed
m-mohr opened this issue Oct 25, 2022 · 0 comments · Fixed by #149
Closed

crs data type: JSON object #128

m-mohr opened this issue Oct 25, 2022 · 0 comments · Fixed by #149
Assignees
@tschaub @m-mohr
Milestone
1.0.0-beta.1

Comments

@m-mohr
Copy link
Collaborator

m-mohr commented Oct 25, 2022

The CRS data type says "JSON object", which could be understood as object serialized as JSON (i.e. a string), so this should probably just say "object"?
@m-mohr m-mohr mentioned this issue Oct 25, 2022
Merged
@cholmes cholmes added this to the 1.0.0-beta.1 milestone Nov 7, 2022
@tschaub tschaub mentioned this issue Nov 22, 2022
Merged
tschaub added a commit that referenced this issue Dec 5, 2022
@m-mohr @tschaub
Clean-up spec and JSON Schema (#131)
7a7826f 
* Update JSON Schema and data types #128, 129

* Allow null for crs again and clarify the data types in the table

* Update to latest changes

* Require min length for column names, don't allow additional (invalid) columns

* Update format-specs/geoparquet.md

Co-authored-by: Matthias Mohr <webmaster@mamo-net.de>

Co-authored-by: Tim Schaub <tschaub@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tschaub tschaub

@m-mohr m-mohr

Labels
None yet
Projects
None yet
Milestone
1.0.0-beta.1
Development

Successfully merging a pull request may close this issue.

More consistent spelling and punctuation for JSON types tschaub/geoparquet
3 participants
@tschaub @cholmes @m-mohr