Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated projjson schema link to 0.7 (and new link) #227

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

cholmes
Copy link
Member

@cholmes cholmes commented Jun 7, 2024

Opening this PR more to continue the discussion in #180, since if we do want to be updating the schema versions than 1.1 release seems like a good time to.

I'm not sure what is the proper url to put in, I used https://proj.org/en/latest/schemas/v0.7/projjson.schema.json as the 'main' one seems to redirect there: https://proj.org/schemas/v0.7/projjson.schema.json But the 'id' is the latter one. There's additional discussion of this in OSGeo/PROJ#4088

The case for updating the schema is that 0.5 -> 0.7 is mostly (all?) additive, so everything in the past should work.

The case against is that we should do something different than hard code in a version number. Or if we have to since that's how schemas work then we should target a new one.

@cholmes cholmes added this to the 1.1 milestone Jun 7, 2024
@jorisvandenbossche
Copy link
Collaborator

I'm not sure what is the proper url to put in, I used https://proj.org/en/latest/schemas/v0.7/projjson.schema.json as the 'main' one seems to redirect there: https://proj.org/schemas/v0.7/projjson.schema.json But the 'id' is the latter one.

Given that the GDAL documentation about PROJJSON still uses the https://proj.org/schemas/v0.7/projjson.schema.json url, I would follow their lead?

format-specs/schema.json Outdated Show resolved Hide resolved
@rouault
Copy link
Contributor

rouault commented Jun 13, 2024

Given that the GDAL documentation about PROJJSON still uses the https://proj.org/schemas/v0.7/projjson.schema.json url, I would follow their lead?

yes, the redirection to the en/latest/ URL is a ReadTheDocs hosting implementation detail

cholmes and others added 2 commits June 16, 2024 16:50
Co-authored-by: Even Rouault <even.rouault@spatialys.com>
@cholmes cholmes merged commit a684d7a into main Jun 17, 2024
2 checks passed
@jorisvandenbossche jorisvandenbossche deleted the projjson_schema_update branch June 17, 2024 17:36
@tschaub
Copy link
Collaborator

tschaub commented Jun 17, 2024

Should this reference in the example metadata also be changed?

"$schema": "https://proj.org/schemas/v0.6/projjson.schema.json",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants