-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for the 1.1.0 release #230
Conversation
It looks like there is another version number in the geoparquet/examples/example_metadata.json Line 138 in a684d7a
|
Good catch, thanks. Will fix it (and at least mention something in the release wiki). |
examples/example_metadata.json
Outdated
@@ -135,6 +135,6 @@ | |||
} | |||
}, | |||
"primary_column": "geometry", | |||
"version": "1.1.0-dev" | |||
"version": "1.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tschaub - I think this is right on this branch. Your link in the comment looks like it goes to the PR for the projjson schema fix - a684d7a. I see it right on the 1.1 release branch.
Let me know if I'm missing anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. Looks right in this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No prob! Thanks for checking. A +1 on the release is appreciated :)
Ok, I think this is all ready to go. Approvals are now open! Our conclusions on the call were as follows: #227 - (projjson schema version update) datemerged And I couldn't find where @tschaub pointed out that the version was off. If reviewers could make sure that there are no 1.1.0-dev versions anywhere on this branch then that'd be much appreciated. I'm aiming for at least 4 +1's before releasing. When we've got that I'll tag the release and push it out. Thanks all! |
Looks like it is the
We could:
Any preferences? |
Good catch. I think for now I lean towards #2, as I'm not clear what it's for, and then at some point get better test data. |
Oh wait, I see, it's meant to be an example of the geoarrow encoding. So probably shouldn't just remove it. Ideally we'd have an example that is actually in the geoarrow encoding in parquet, not just the metadata. |
I updated the version in |
This branch prepares everything for release, in the hopes of being able to discuss the final issues in the next meeting and finalize the release. The remaining issues to discuss and potentially merge includes:
#227 - schema version for projjson
#198 - antimeridian crossing - @jorisvandenbossche had some potential ideas.
#123 - Test data - not sure if Joris had a couple more he wanted to get in.
#229 - version compatibility suggestion that just landed, but seems pretty good.