Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for the 1.1.0 release #230

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Updates for the 1.1.0 release #230

merged 4 commits into from
Jun 19, 2024

Conversation

cholmes
Copy link
Member

@cholmes cholmes commented Jun 17, 2024

This branch prepares everything for release, in the hopes of being able to discuss the final issues in the next meeting and finalize the release. The remaining issues to discuss and potentially merge includes:

#227 - schema version for projjson
#198 - antimeridian crossing - @jorisvandenbossche had some potential ideas.
#123 - Test data - not sure if Joris had a couple more he wanted to get in.
#229 - version compatibility suggestion that just landed, but seems pretty good.

@tschaub
Copy link
Collaborator

tschaub commented Jun 17, 2024

It looks like there is another version number in the example_metadata.json file that needs to be manually updated as part of the release process (alternatively, maybe the scripts/generate_example.py script could be updated to generate this file so we have fewer places to update version numbers).

"version": "1.1.0-dev"

@cholmes
Copy link
Member Author

cholmes commented Jun 17, 2024

It looks like there is another version number in the example_metadata.json file that needs to be manually updated as part of the release process (alternatively, maybe the scripts/generate_example.py script could be updated to generate this file so we have fewer places to update version numbers).

Good catch, thanks. Will fix it (and at least mention something in the release wiki).

@@ -135,6 +135,6 @@
}
},
"primary_column": "geometry",
"version": "1.1.0-dev"
"version": "1.1.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tschaub - I think this is right on this branch. Your link in the comment looks like it goes to the PR for the projjson schema fix - a684d7a. I see it right on the 1.1 release branch.

Let me know if I'm missing anything.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. Looks right in this change.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No prob! Thanks for checking. A +1 on the release is appreciated :)

@cholmes
Copy link
Member Author

cholmes commented Jun 18, 2024

Ok, I think this is all ready to go. Approvals are now open! Our conclusions on the call were as follows:

#227 - (projjson schema version update) datemerged
#198 - (antimeridian crossing) - we don't feel like we have a great solution all ready, so moving to 1.2 and retaining the official guidance of just saying 'don't do that'.
#123 - Test data - Joris may try to get something in, but there's lots more test data, we're just missing some for 1.0, which we didn't have for 1.0 anyways, so we decided not to block on this (but he may try to get it in soon).
#229 - (version compatibility) merged - with a bit of back and forth on 'forward compatibility'.

And I couldn't find where @tschaub pointed out that the version was off. If reviewers could make sure that there are no 1.1.0-dev versions anywhere on this branch then that'd be much appreciated.

I'm aiming for at least 4 +1's before releasing. When we've got that I'll tag the release and push it out. Thanks all!

@tschaub
Copy link
Collaborator

tschaub commented Jun 18, 2024

Looks like it is the example_metadata_point.json file that has the wrong version number:

"version": "1.1.0-dev"

We could:

  1. manually update the version number in this file as well and update the release process so that others do the same in the future
  2. remove this file (not clear to me that it is used)
  3. update things so that this file is generated from a corresponding example_point.parquet file (that would be generated from the generate_example.py script and would mean fewer version numbers to maintain)

Any preferences?

@cholmes
Copy link
Member Author

cholmes commented Jun 18, 2024

Good catch.

I think for now I lean towards #2, as I'm not clear what it's for, and then at some point get better test data.

@cholmes
Copy link
Member Author

cholmes commented Jun 18, 2024

Oh wait, I see, it's meant to be an example of the geoarrow encoding. So probably shouldn't just remove it. Ideally we'd have an example that is actually in the geoarrow encoding in parquet, not just the metadata.

@tschaub
Copy link
Collaborator

tschaub commented Jun 18, 2024

I updated the version in example_metadata_point.json and opened #232 to suggest consolidating the example/test data.

@cholmes cholmes merged commit 569b341 into main Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants