Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Collection classes #150

Merged
merged 6 commits into from
Jun 30, 2021
Merged

Add Collection classes #150

merged 6 commits into from
Jun 30, 2021

Conversation

dr-shorthair
Copy link
Collaborator

Fixes #148

@dr-shorthair dr-shorthair added the enhancement New feature or request label Jun 3, 2021
@dr-shorthair dr-shorthair added this to the GeoSPARQL 1.1 milestone Jun 3, 2021
Update geo.ttl
0da3976 
indentation
@situx
Copy link
Collaborator

situx commented Jun 4, 2021

@dr-shorthair Would it make sense to also include query functions for GeometryN and NumGeometries from the Simple Features for SQL if we included GeometryCollections in the spec?

@dr-shorthair
Copy link
Collaborator Author

Yes - I had only chased down (most of?) the static aspects.

@situx
Copy link
Collaborator

situx commented Jun 4, 2021

Okay, I can add another pull request adding those functions, as I am currently updating the comparison table for SQL.

nicholascar
nicholascar approved these changes Jun 9, 2021
View reviewed changes
Copy link
Collaborator

@nicholascar nicholascar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The PR is in draft but it should be merged in and then I'll follow-up with additions to the Annex B: Examples

@nicholascar
Copy link
Collaborator

@dr-shorthair are you going to merge this or add new things to it, since it's still in draft? If you were going to add bits, consider the Annex B: Examples.

@dr-shorthair
Copy link
Collaborator Author

I'm waiting for consensus on #148 - a couple of open questions there.

@nicholascar nicholascar mentioned this pull request Jun 13, 2021
Merged
@nicholascar nicholascar mentioned this pull request Jun 18, 2021
Closed
@nicholascar
Copy link
Collaborator

Based on discussion in #148, can this PR be either brought out of draft or withdrawn by early to mid July? This is so we can finalise standing PRs and submit GeoSPARQL 1.1 for wider review at the end of July.

@nicholascar
Copy link
Collaborator

@dr-shorthair can you please move this out of draft given the status of conversation in #148?

@dr-shorthair dr-shorthair marked this pull request as ready for review June 30, 2021 02:03
@nicholascar nicholascar merged commit b1d814b into master Jun 30, 2021
@nicholascar nicholascar deleted the issue148-collections branch June 30, 2021 15:07
@FransKnibbe FransKnibbe mentioned this pull request Aug 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@situx situx situx approved these changes

@nicholascar nicholascar nicholascar approved these changes

@FransKnibbe FransKnibbe Awaiting requested review from FransKnibbe

@pvretano pvretano Awaiting requested review from pvretano

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
GeoSPARQL 1.1
Development

Successfully merging this pull request may close these issues.

Add geo:FeatureCollection
3 participants
@dr-shorthair @situx @nicholascar