Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention role of CRS in geometric computations #245

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

FransKnibbe
Copy link
Collaborator

Adds a paragraph about the role of CRS in geometric computations to the Geometry extension section.
Resolves issue 201.

Copy link
Collaborator

@situx situx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Frans and welcome back!
Looks good to me, but you created a link that leads to a page with an exception (the CRS84 link). Could you correct that before the PR is merged?

fix CRS84 hyperlink labels
@FransKnibbe
Copy link
Collaborator Author

FransKnibbe commented Dec 6, 2021

@situx: I copied the hyperlink from elsewhere in the specification. I see now that the actual hyperlink (http://www.opengis.net/def/crs/OGC/1.3/CRS84) is correct, but its text label (http://www.opengis.net/def/crs/OGC/1.3/84) was not. The part "CRS" is missing before "84". Both occurrences (I could find no other) are fixed now.
It seems I myself was to blame for removing "CRS" from the original hyperlink before I copied it. How good of you to notice.

@FransKnibbe FransKnibbe changed the title Update 11-Part-08.adoc Remark role of CRS in geometric computations Dec 8, 2021
@FransKnibbe FransKnibbe added the documentation Improvements or additions to documentation label Dec 8, 2021
@FransKnibbe FransKnibbe changed the title Remark role of CRS in geometric computations Mention role of CRS in geometric computations Dec 8, 2021
@nicholascar nicholascar merged commit f4f20f9 into master Dec 15, 2021
@nicholascar nicholascar deleted the Role-of-CRS-in-Geometric-computations branch December 15, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify computations on geodetic coordinates
3 participants