Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build behind corporate proxy #416

Closed
dgjbge opened this issue Nov 7, 2019 · 3 comments · Fixed by #417
Closed

Unable to build behind corporate proxy #416

dgjbge opened this issue Nov 7, 2019 · 3 comments · Fixed by #417
Assignees
Projects
Milestone

Comments

@dgjbge
Copy link

dgjbge commented Nov 7, 2019

This project does not build when run behind a corporate proxy because the core tests validateWithMismatchedDTDList and parseWithSchemaListAndDifferentLocation in com.occamlab.te.parsers.XMLValidatingParserTest make external HTTP calls (e.g. validateWithMismatchedDTDList make a request to schemas.opengis.net).

Would it be possible to either not make external HTTP requests (ie keep schemas local, which would allow tests to be run offline) or allow proxy settings to be sent to surefile via argline, e.g. https://stackoverflow.com/a/32294928/228971 ?

This would allow the project to be built inside corporate IT environments where developers might be unlucky enough to have to deal with proxies :-(

@dstenger dstenger self-assigned this Nov 27, 2019
@dstenger
Copy link
Contributor

Thank you for reporting.

Does the build work behind a corporate proxy if you are skipping the tests (-DskipTests)?
I agree that the test resources shouldn't come from a remote location.

@dstenger dstenger added this to To do in CITE via automation Nov 27, 2019
@dstenger dstenger moved this from To do to In progress in CITE Nov 27, 2019
@dgjbge
Copy link
Author

dgjbge commented Nov 27, 2019

Yes, skipping tests works

@dstenger
Copy link
Contributor

@keshav-nangare Can you please try to remove the external references in unit tests? Instead, the resources shall be added to the repository.

@dstenger dstenger assigned keshavnangare and unassigned dstenger Nov 27, 2019
keshavnangare pushed a commit that referenced this issue Dec 5, 2019
@keshavnangare keshavnangare moved this from In progress to To verify in CITE Dec 11, 2019
@dstenger dstenger assigned dstenger and lgoltz and unassigned keshavnangare Dec 11, 2019
CITE automation moved this from To verify to Done May 15, 2020
@dstenger dstenger added this to the 5.5 milestone May 15, 2020
@dstenger dstenger modified the milestones: 5.5, 5.4.1 Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
CITE
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants