Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #589 #597

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Closes #589 #597

merged 6 commits into from
Dec 14, 2023

Conversation

bpross-52n
Copy link
Contributor

Closes #589

@dstenger
Copy link
Contributor

@bpross-52n Can you please change charset='utf-8' to charset=utf-8 in all classes/occurrences?
Also, please do some further testing.

@dstenger dstenger mentioned this pull request Nov 10, 2023
@dstenger dstenger self-requested a review December 8, 2023 17:49
Copy link
Contributor

@dstenger dstenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When testing the branch with java17Tomcat101TeamEngine6 branch of ets-wms13 via executing mvn clean install site docker:run -Pintegration-tests,docker, I get the following error:

...
[ERROR] <!doctype html><html lang="en"><head><title>HTTP Status 500 – Internal Server Error</title><style type="text/css">body {font-family:Tahoma,Arial,sans-serif;} h1, h2, h3, b {color:white;background-color:#525D76;} h1 {font-size:22px;} h2 {font-size:16px;} h3 {font-size:14px;} p {font-size:12px;} a {color:black;} .line {height:1px;background-color:#525D76;border:none;}</style></head><body><h1>HTTP Status 500 – Internal Server Error</h1><hr class="line" /><p><b>Type</b> Exception Report</p><p><b>Message</b> Request failed.</p><p><b>Description</b> The server encountered an unexpected condition that prevented it from fulfilling the request.</p><p><b>Exception</b></p><pre>jakarta.servlet.ServletException: java.lang.UnsupportedOperationException: This MultivaluedMap implementation is immutable.
[ERROR] 	org.glassfish.jersey.servlet.WebComponent.serviceImpl(WebComponent.java:409)
[ERROR] 	org.glassfish.jersey.servlet.WebComponent.service(WebComponent.java:346)
[ERROR] 	org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:357)
[ERROR] 	org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:311)
[ERROR] 	org.glassfish.jersey.servlet.ServletContainer.service(ServletContainer.java:205)
[ERROR] 	org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
[ERROR] 	com.occamlab.te.realm.RestAuthenticationFilter.doFilter(RestAuthenticationFilter.java:72)
[ERROR] </pre><p><b>Root Cause</b></p><pre>java.lang.UnsupportedOperationException: This MultivaluedMap implementation is immutable.
[ERROR] 	org.glassfish.jersey.internal.util.collection.ImmutableMultivaluedMap.put(ImmutableMultivaluedMap.java:123)
[ERROR] 	org.glassfish.jersey.internal.util.collection.ImmutableMultivaluedMap.put(ImmutableMultivaluedMap.java:36)
[ERROR] 	com.occamlab.te.spi.jaxrs.resources.TestRunResource.executeTestRun(TestRunResource.java:391)
[ERROR] 	com.occamlab.te.spi.jaxrs.resources.TestRunResource.handleGetZip(TestRunResource.java:128)
...

Thus, the workaround with the immutable map seems not to work.

When the integration tests are not executed, the test suite can be built and started.

The error occurs when application/zip is set as Accept header:

@dstenger
Copy link
Contributor

dstenger commented Dec 8, 2023

Also, I added a commit which excludes all jersey dependencies from TEAM Engine webapp as those libraries are already part of common-libs assembly which is unpacked to tomcat/lib/.

@dstenger dstenger added this to the 6.0 milestone Dec 14, 2023
@dstenger
Copy link
Contributor

@bpross-52n Is this issue ready to be reviewed again?

@dstenger dstenger self-requested a review December 14, 2023 13:27
@bpross-52n
Copy link
Contributor Author

@dstenger Yes, I finalized this.

@dstenger dstenger merged commit d0e7a04 into 6.0 Dec 14, 2023
@dstenger dstenger deleted the issue#589 branch December 18, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants