Skip to content

Commit

Permalink
Merge pull request #5245 from opengisch/ts
Browse files Browse the repository at this point in the history
Sign windows installer
  • Loading branch information
m-kuhn committed May 17, 2024
2 parents fe07137 + b7237bc commit 0538ab6
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 3 deletions.
20 changes: 18 additions & 2 deletions .github/workflows/windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ jobs:

- name: 🧽 Developer Command Prompt for Microsoft Visual C++
uses: ilammy/msvc-dev-cmd@v1
with:
# with:
# See https://github.com/actions/runner-images/issues/9398
toolset: 14.39
# toolset: 14.39

- name: 🔨 Prepare build env
shell: bash
Expand Down Expand Up @@ -125,6 +125,22 @@ jobs:
name: package-logs-x64-windows-static
path: ${{ env.CMAKE_BUILD_DIR }}/_CPack_Packages/**/*.log

- name: 🎭 Sign
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && env.ARTIFACT_NAME != null
uses: azure/trusted-signing-action@v0.3.16
with:
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
azure-client-secret: ${{ secrets.AZURE_CLIENT_SECRET }}
endpoint: https://weu.codesigning.azure.net/
code-signing-account-name: OPENGISch
certificate-profile-name: OPENGISch
files-folder: ${{ env.CMAKE_BUILD_DIR }}
files-folder-filter: exe,msi
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256

- name: 📦 Upload package
if: ${{ env.ARTIFACT_NAME != null }}
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion vcpkg/triplets/x64-windows-static.cmake
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE static)
set(VCPKG_LIBRARY_LINKAGE static)
set(VCPKG_PLATFORM_TOOLSET_VERSION "14.38") # Can be removed in a future update; aligned with .github/workflows/windows.yml : ilammy/msvc-dev-cmd/toolset
# set(VCPKG_PLATFORM_TOOLSET_VERSION "14.38") # Can be removed in a future update; aligned with .github/workflows/windows.yml : ilammy/msvc-dev-cmd/toolset

set(VCPKG_BUILD_TYPE release)

1 comment on commit 0538ab6

@qfield-fairy
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.