Use a readonly property and document minimum item count limit

opengisch · Apr 23, 2024 · b0e7de8 · b0e7de8
1 parent f9a98b4
commit b0e7de8
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/qml/editorwidgets/ValueMap.qml b/src/qml/editorwidgets/ValueMap.qml
@@ -121,11 +121,15 @@ EditorWidgetBase {
         Layout.preferredWidth: enabled ? 48 : 0
         Layout.preferredHeight: 48
 
+        // Using the search when there are less than X items in the dropdown proves to be poor UI on normally
+        // sized and oriented phones. Some empirical tests proved 6 to be a good number for now.
+        readonly property int minimumItemCount: 6
+
         bgcolor: "transparent"
         iconSource: Theme.getThemeIcon("ic_baseline_search_black")
         iconColor: Theme.mainTextColor
 
-        visible: enabled && comboBox.count > 6 // Make value map searchable only if it contains more than 6 items
+        visible: enabled && comboBox.count >= minimumItemCount
 
         onClicked: {
             searchFeaturePopup.open()