Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layer resolver #1589

Merged
merged 2 commits into from Jan 12, 2021
Merged

Add layer resolver #1589

merged 2 commits into from Jan 12, 2021

Conversation

m-kuhn
Copy link
Member

@m-kuhn m-kuhn commented Jan 10, 2021

For reasons, layer ids configured in value relations do not always match with the id of the layer they refer to.
In these cases QGIS resorts to advanced detection techniques to resolve the layer anyway.
Let's do the same with a nice declarative approach.

For reasons, layer ids configured in value relations do not always match.
In these cases QGIS resorts to advanced detection techniques to find the
layer anyway.
Let's do the same with a nice declarative approach.
@qfield-fairy

This comment has been minimized.

@qfield-fairy

This comment has been minimized.

@qfield-fairy
Copy link
Collaborator

🎉 Ta-daaa, freshly created APKs are available for 42508ff:

Other architectures: armv7, x86_64, x86

@signedav
Copy link
Member

Does this mean it worked never on offline projects because it always used the id only?

@m-kuhn
Copy link
Member Author

m-kuhn commented Jan 11, 2021

I think the offline editing plugin adjusts the ids, so I think it was no problem there.
I could imagine that this one here is to saving / restoring qml, but the complete process to get to a "broken" configuration is not known to me.

Copy link
Member

@signedav signedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good. Didn't test the apk.

@m-kuhn m-kuhn merged commit 6ab5640 into master Jan 12, 2021
@m-kuhn m-kuhn deleted the layerResolver branch January 12, 2021 09:36
github-actions bot pushed a commit that referenced this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants