Add support for Happy IMU correction #4214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for f43157a: arm64-android |
|
@nirvn thanks for the review! I still have to test with the real device |
nirvn
reviewed
Apr 22, 2023
nirvn
reviewed
Apr 23, 2023
nirvn
reviewed
Apr 23, 2023
|
@nirvn I tested out a bit this morning with the device and seems to work correctly. I have verified the cantonal official measurement arounds my office 😁 This things are still missing:
|
|
@domi4484 , let's maybe discuss the constraint and UI parts in a call and commit the remaining improvements individually in separate PRs. We'll have to be quite conscious of not wanting to overtake the UI with IMU-specific elements. |
nirvn
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.