Qt6 QML polishing #4318
Merged
Qt6 QML polishing #4318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 7170b35: arm64-android |
m-kuhn
reviewed
May 30, 2023
| @@ -86,6 +86,11 @@ int main( int argc, char **argv ) | |||
| return 0; | |||
| } | |||
|
|
|||
| #if QT_VERSION >= QT_VERSION_CHECK( 6, 5, 1 ) | |||
| // Avoids systematic crash after first launch, a regression in Qt >= 6.5.1 | |||
There was a problem hiding this comment.
Can we have a link to an issue or elsewhere, to check if this is still valid in the future?
There was a problem hiding this comment.
@m-kuhn , see #4319 (comment)
m-kuhn
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polishing QField under Qt6, fixing our use of QML properties under Material 3 (i.e. Qt >= 6.5).