Fix Qt >= 6.5.1 crasher, re-enable disk cache #4463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 2ac482f: arm64-android |
nirvn
commented
Jul 22, 2023
| @@ -28,6 +28,8 @@ ProjectInfo::ProjectInfo( QObject *parent ) | |||
| : QObject( parent ) | |||
| { | |||
| mSaveExtentTimer.setSingleShot( true ); | |||
| mSaveRotationTimer.setSingleShot( true ); | |||
There was a problem hiding this comment.
@m-kuhn , found this issue while dissecting why Qt6 builds were showing some brief pauses every ~1sec when dragging the canvas. Turns out we were running these timers at infinity once triggered. That's... terrible! 😱
m-kuhn
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIL: aliasing an alias isn't something Qt6 likes (and really, isn't something we should do anyways).