-
-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip antenna height correction when IMU is active #4503
Conversation
7c33e7a
to
dcdbe6c
Compare
🎉 Ta-daaa, freshly created APKs are available for dcdbe6c: arm64-android |
@domi4484 , I was re-thinking about this earlier today, and I don't think we can apply the antenna height at the receiver level, as it'll likely mess up (infinitely small value but still) vertical grid shift calculation here. We ultimately need to add the antenna height value after we transformed the QgsPoint( lat, lon, elevation ) to the desired destination CRS. So, I think we're back to handling this in the Positioning class, and insure that the destination point's Z value has the antenna height added after the transformation. |
I see only a small problematic with that approach:
Well if the difference is in infinitely small range maybe better keep it consistent between modes? |
@domi4484 , fair point. |
@nirvn I tried to restart the test but the ios is still failing when downloading qt... Can I merge anyway? |
@domi4484 , yeah go ahead |
Apparently I can't skip merge protections... |
Merging even if iOS did not build, QT download still fails |
* Skip antenna height correction when IMU is active * Move antenna height logic to the receiver
* Skip antenna height correction when IMU is active * Move antenna height logic to the receiver
When IMU is active, the GNSS device provides the position at the end of the pole.
The antenna height must not be subtracted again from the Z value.