Implementation of basic image attachment sketching capability #5149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for de24f0c: arm64-android |
nirvn
force-pushed
the
sketch
branch
9 times, most recently
from
93afc61
to
d05b118
Compare
|
Esto se podría usar a futuro para recopilar firmas digitales... |
nirvn
commented
Mar 30, 2024
nirvn
force-pushed
the
sketch
branch
4 times, most recently
from
31b6eb5
to
3a4eec5
Compare
nirvn
force-pushed
the
sketch
branch
3 times, most recently
from
a26ecb2
to
9d269ff
Compare
…le against white or black background
… menu, add drawing item
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
domi4484
approved these changes
Apr 9, 2024
domi4484
approved these changes
Apr 9, 2024
|
Alright let's merge and deal with those lingering issues in separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an in-house drawing/sketching functionality to QField, and exposes it in the attachment widget allowing for users to quickly sketch over images they have taken.
Video showing UI to add a new drawing (blank or based on template) as attachment:
Screencast.from.2024-03-29.17-43-43.webm
Video showing UI/UX to draw over pre-existing image attachment:
Screencast.from.2024-03-28.14-06-47.webm
The UI is minimalist in nature and aims at being light while offering basic functionalities needed. Follow up PRs will cover sketch background templates and more UI changes to expose e.g. sketching from scratch attachment.