Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign windows installer #5245

Merged
merged 6 commits into from
May 17, 2024
Merged

Sign windows installer #5245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26cdc9a
Sign
m-kuhn May 14, 2024
9a91a4d
Sign every build
m-kuhn May 15, 2024
fb04bde
Update windows.yml
m-kuhn May 16, 2024
b381b86
Update x64-windows-static.cmake
m-kuhn May 16, 2024
b649cb1
Only sign releases
m-kuhn May 17, 2024
b7237bc
whitespacing
m-kuhn May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ jobs:

- name: 🧽 Developer Command Prompt for Microsoft Visual C++
uses: ilammy/msvc-dev-cmd@v1
with:
# with:
# See https://github.com/actions/runner-images/issues/9398
toolset: 14.39
# toolset: 14.39

- name: 🔨 Prepare build env
shell: bash
Expand Down Expand Up @@ -125,6 +125,22 @@ jobs:
name: package-logs-x64-windows-static
path: ${{ env.CMAKE_BUILD_DIR }}/_CPack_Packages/**/*.log

- name: 🎭 Sign
if: github.event_name == 'release' && startsWith(github.ref, 'refs/tags/v') && env.ARTIFACT_NAME != null
uses: azure/trusted-signing-action@v0.3.16
with:
azure-tenant-id: ${{ secrets.AZURE_TENANT_ID }}
azure-client-id: ${{ secrets.AZURE_CLIENT_ID }}
azure-client-secret: ${{ secrets.AZURE_CLIENT_SECRET }}
endpoint: https://weu.codesigning.azure.net/
code-signing-account-name: OPENGISch
certificate-profile-name: OPENGISch
files-folder: ${{ env.CMAKE_BUILD_DIR }}
files-folder-filter: exe,msi
file-digest: SHA256
timestamp-rfc3161: http://timestamp.acs.microsoft.com
timestamp-digest: SHA256

- name: 📦 Upload package
if: ${{ env.ARTIFACT_NAME != null }}
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion vcpkg/triplets/x64-windows-static.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
set(VCPKG_TARGET_ARCHITECTURE x64)
set(VCPKG_CRT_LINKAGE static)
set(VCPKG_LIBRARY_LINKAGE static)
set(VCPKG_PLATFORM_TOOLSET_VERSION "14.38") # Can be removed in a future update; aligned with .github/workflows/windows.yml : ilammy/msvc-dev-cmd/toolset
# set(VCPKG_PLATFORM_TOOLSET_VERSION "14.38") # Can be removed in a future update; aligned with .github/workflows/windows.yml : ilammy/msvc-dev-cmd/toolset

set(VCPKG_BUILD_TYPE release)
Loading