Implement margins concept for map canvas #5252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 07ddbca: arm64-android |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
mohsenD98
approved these changes
May 20, 2024
| color: "#ffffff" | ||
| radius: 8 | ||
| } | ||
| color: "#bbfafafa" |
There was a problem hiding this comment.
shouldn't we use Theme.mainBackgroundColorSemiOpaque as background color?
Result of using Theme.mainBackgroundColorSemiOpaque:
Then i think instrutionLabel style should change.
There was a problem hiding this comment.
@mohsenD98 , we have to hard code it for now because the elevation plotting canvas doesn't expose a property to set the label color yet (and therefore the result is bad on dark theme ATM)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the concept of margins (bottom and right for now) to the map canvas. Those margins allow for us to overlay elements on top of the map canvas and take those margins into account when setting the map extent / center.
Practically speaking, this allows for zooming to feature / point to recenter around the portion of the map that's not covered by overlaid elements.
Needed for the ongoing revamp of information panel -> drawer (see #5251)
Here's a screencast of what it does:
vokoscreenNG-2024-05-20_11-55-05.mp4
Note how the auto re-centering to positioning and destination is contained within the part of the map canvas that's not partially hidden by the information drawer. Big win! This was not needed before as we were shrinking the map canvas to show information below it (booouh;) ).
Margin magic in action, this time with zooming into features:
vokoscreenNG-2024-05-20_13-56-04.mp4
You can see the feature nicely fits within the top-left region that's not obstructed by either the feature form nor the information drawers.