Add remaining properties needed to unlock beautiful dark theme support to the elevation profile canvas #5260
Conversation
|
🎉 Ta-daaa, freshly created APKs are available for a7869e6: arm64-android |
…t to the elevation profile canvas
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -18,7 +18,12 @@ | |||
|
|
|||
| #include "qgsabstractprofilegenerator.h" | |||
| #include "qgsabstractprofilesource.h" | |||
| #include "qgscolorutils.h" | |||
| #include "qgsexpressioncontextutils.h" | |||
There was a problem hiding this comment.
warning: included header qgscolorutils.h is not used directly [misc-include-cleaner]
| #include "qgsexpressioncontextutils.h" | |
| #include "qgsexpressioncontextutils.h" |
| void QgsQuickElevationProfileCanvas::setBackgroundColor( const QColor &color ) | ||
| { | ||
| if ( mBackgroundColor == color ) | ||
| return; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| return; | |
| if ( mBackgroundColor == color ) { | |
| return; | |
| } |
| void QgsQuickElevationProfileCanvas::setBorderColor( const QColor &color ) | ||
| { | ||
| if ( mBorderColor == color ) | ||
| return; |
There was a problem hiding this comment.
warning: statement should be inside braces [readability-braces-around-statements]
| return; | |
| if ( mBorderColor == color ) { | |
| return; | |
| } |
| @@ -775,6 +812,16 @@ | |||
| textFormat.setSizeUnit( Qgis::RenderUnit::Points ); | |||
| mPlotItem->yAxis().setTextFormat( textFormat ); | |||
|
|
|||
| std::unique_ptr<QgsSimpleLineSymbolLayer> lineSymbolLayer = std::make_unique<QgsSimpleLineSymbolLayer>( mBorderColor, 0.1 ); | |||
| lineSymbolLayer->setPenCapStyle( Qt::FlatCap ); | |||
There was a problem hiding this comment.
warning: no header providing "Qt::FlatCap" is directly included [misc-include-cleaner]
lineSymbolLayer->setPenCapStyle( Qt::FlatCap );
^| @@ -775,6 +812,16 @@ | |||
| textFormat.setSizeUnit( Qgis::RenderUnit::Points ); | |||
| mPlotItem->yAxis().setTextFormat( textFormat ); | |||
|
|
|||
| std::unique_ptr<QgsSimpleLineSymbolLayer> lineSymbolLayer = std::make_unique<QgsSimpleLineSymbolLayer>( mBorderColor, 0.1 ); | |||
| lineSymbolLayer->setPenCapStyle( Qt::FlatCap ); | |||
| mPlotItem->xAxis().setGridMinorSymbol( new QgsLineSymbol( QgsSymbolLayerList( { lineSymbolLayer->clone() } ) ) ); | |||
There was a problem hiding this comment.
warning: no header providing "QgsSymbolLayerList" is directly included [misc-include-cleaner]
src/core/qgsquick/qgsquickelevationprofilecanvas.cpp:40:
+ #include <qgssymbol.h>| * | ||
| * \see setBackgroundColor | ||
| */ | ||
| QColor backgroundColor() const; |
There was a problem hiding this comment.
warning: no header providing "QColor" is directly included [misc-include-cleaner]
src/core/qgsquick/qgsquickelevationprofilecanvas.h:25:
+ #include <qcolor.h>| @@ -292,6 +328,8 @@ | |||
|
|
|||
| bool mDirty = false; | |||
|
|
|||
| QColor mBackgroundColor = QColor( 255, 255, 255 ); | |||
There was a problem hiding this comment.
warning: 255 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers]
QColor mBackgroundColor = QColor( 255, 255, 255 );
^| @@ -292,6 +328,8 @@ | |||
|
|
|||
| bool mDirty = false; | |||
|
|
|||
| QColor mBackgroundColor = QColor( 255, 255, 255 ); | |||
There was a problem hiding this comment.
warning: 255 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers]
QColor mBackgroundColor = QColor( 255, 255, 255 );
^| @@ -292,6 +328,8 @@ | |||
|
|
|||
| bool mDirty = false; | |||
|
|
|||
| QColor mBackgroundColor = QColor( 255, 255, 255 ); | |||
There was a problem hiding this comment.
warning: 255 is a magic number; consider replacing it with a named constant [cppcoreguidelines-avoid-magic-numbers]
QColor mBackgroundColor = QColor( 255, 255, 255 );
^
Light theme:
Dark theme:
