Fix wrong usage of 'exclude' for the clang-tidy CI check #5262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for d68308e: arm64-android |
m-kuhn
approved these changes
May 22, 2024
|
@m-kuhn , this list was derived from the default value (see https://github.com/ZedThree/clang-tidy-review?tab=readme-ov-file#inputs), which had a bunch of *. |
|
Merge ahead if you feel confident about it, you've seen a couple of feedback already |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exclude parameter covers files, not check names. I've tried to come up with a narrower set of checks to insure we actually look at what's being told to us vs. ignoring :)