Sync tabs with swipe view in FeatureForm. #5281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also fix elide in MapValue.qml by setting a width.
|
🎉 Ta-daaa, freshly created APKs are available for 5fe5929: arm64-android |
nirvn
reviewed
May 31, 2024
nirvn
reviewed
May 31, 2024
src/qml/FeatureForm.qml
Outdated
| /** | ||
| * The main form content area | ||
| */ | ||
| SwipeView { | ||
| id: swipeView | ||
| Layout.fillWidth: true | ||
| Layout.fillHeight: true | ||
| currentIndex: tabRow.currentIndex | ||
| currentIndex: tabBarListView.currentIndex |
There was a problem hiding this comment.
For the sake of avoiding noise, I would actually keep the same id, i.e. tabRow.
nirvn
reviewed
May 31, 2024
mohsenD98
changed the title
mohsenD98
changed the title
nirvn
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we address two minor issues:
1- Fix #5242: The issue where tabs are not following the selected container has been resolved.
2- Additionally, we've fixed the elide problem in MapValue.
These changes aim to improve the overall user experience and stability of application.
Resolved video:
Screencast.from.2024-05-31.07-34-16.webm