Avoid flagging internal positioning device as invalid caused by access error, cleanup positioning includes #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirvn
force-pushed
the
macos_access_header_cleanuo
branch
from
5b92675
to
f51229f
Compare
…s error, cleanup positioning includes
nirvn
force-pushed
the
macos_access_header_cleanuo
branch
from
f51229f
to
6ce418d
Compare
|
🎉 Ta-daaa, freshly created APKs are available for 337869e: arm64-android |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The macos spix tests already revealed something interesting: on that platform, when creating the internal positioning device, we get an AccessError (as permission has not yet been asked to the user). However in our code, we invalidate the device upon creation when any error is detected. This PR addresses that by allowing for the device to be created, allowing for users to ask for permission afterwards when turning the positioning on.
I've also taken the opportunity to cleanup obsolete includes.