Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins permission UI/UX improvements #5331

Merged
merged 3 commits into from
Jun 15, 2024
Merged

Plugins permission UI/UX improvements #5331

merged 3 commits into from
Jun 15, 2024

Conversation

nirvn
Copy link
Member

@nirvn nirvn commented Jun 15, 2024 •
edited
Loading

Fixing a couple of issues identified while preparing the plugins blog post:

  • It's way too easy to hit the clear permissions button, I've moved it into a dropdown menu attached to the install plugins button. Bonus: makes the UI look a lot better on screen with narrow height (e.g. a phone in landscape orientation).
  • The permission clearing logic was broken for app-wide plugins, fixed that.

How it looks now:
Screenshot from 2024-06-15 09-58-34

Dropdown menu:
image

@qfield-fairy
Copy link
Collaborator

qfield-fairy commented Jun 15, 2024 •
edited
Loading

🎉 Ta-daaa, freshly created APKs are available for 0a664bf: arm64-android

Other architectures

@nirvn nirvn enabled auto-merge (rebase) June 15, 2024 10:51
@nirvn nirvn merged commit df81406 into master Jun 15, 2024
23 checks passed
@nirvn nirvn deleted the plugins_permission_imp branch June 15, 2024 10:52
@qfield-fairy qfield-fairy mentioned this pull request Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-kuhn m-kuhn m-kuhn approved these changes

Assignees
No one assigned
Labels
backport release-3_3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nirvn @qfield-fairy @m-kuhn