Instead of reloading a whole project, reset data sources #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
🎉 Ta-daaa, freshly created APKs are available for a6ee8c9: arm64-android |
m-kuhn
reviewed
Jun 17, 2024
| @@ -83,7 +85,15 @@ bool QFieldAppAuthRequestHandler::handleLayerLogins() | |||
| } | |||
| else | |||
| { | |||
| emit reloadEverything(); | |||
| const QList<QgsMapLayer *> mapLayers = QgsProject::instance()->mapLayers().values(); | |||
There was a problem hiding this comment.
Can we inject the QgsProject instead (as a property)?
It's already here: https://github.com/opengisch/QField/blob/master/src/core/qgismobileapp.cpp#L264 and the appauthrequesthandler is created in the same source file, so could easily be injected.
m-kuhn
reviewed
Jun 17, 2024
| { | ||
| if ( !mapLayer->isValid() && mapLayer->dataProvider() ) | ||
| { | ||
| mapLayer->setDataSource( mapLayer->source(), mapLayer->name(), mapLayer->dataProvider()->name() ); |
There was a problem hiding this comment.
If I'm not mistaken, that forces a reload of the datasource?
If that's the goal of this line, a comment would be justified, that's not immediately clear for a reader.
|
A good thing 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ATM, we force reload a whole project to apply credentials for as few as a single layer. Let's be more surgical about things :)
@m-kuhn , keen to hear what you think of this alternative approach.