Variable Editor: First step of redesign #5352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Ta-daaa, freshly created APKs are available for 6580daf: arm64-android |
nirvn
approved these changes
Jun 19, 2024
nirvn
reviewed
Jun 20, 2024
src/qml/VariableEditor.qml
Outdated
| contentWidth: variableNameText.implicitWidth | ||
| duration: shouldAutoFlick ? Math.abs(variableNameText.width - width) * 100 + 10 : 10000 | ||
|
|
||
| contents: TextField { |
There was a problem hiding this comment.
We don't actually need contents: here right? I'd just add the TextField there.
There was a problem hiding this comment.
thanks, just removed it.
from PR review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the initial step in the redesign of the VariableEditor component. In this iteration, we have taken the first step towards the makeover by removing the background color from rows. Additionally, we have addressed indentation issues and applied some cosmetic improvements to the QML code.
New look: