-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release-3_3] Legend badge visual glitche + a pair of value map issues addressed #5361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
{ | ||
beginInsertRows( QModelIndex(), 0, list.size() ); | ||
beginInsertRows( QModelIndex(), 0, list.size() - 1 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: narrowing conversion from 'qsizetype' (aka 'long long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
beginInsertRows( QModelIndex(), 0, list.size() - 1 );
^
@@ -55,7 +55,7 @@ | |||
const QVariantMap valueMap = map.toMap(); | |||
if ( !valueMap.empty() ) | |||
{ | |||
beginInsertRows( QModelIndex(), 0, valueMap.size() ); | |||
beginInsertRows( QModelIndex(), 0, valueMap.size() - 1 ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: narrowing conversion from 'size_type' (aka 'long long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
beginInsertRows( QModelIndex(), 0, valueMap.size() - 1 );
^
🎉 Ta-daaa, freshly created APKs are available for bccd4ba: arm64-android |
Backport #5355
Authored by: @nirvn