Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value Relation Widget #600

Merged
merged 26 commits into from
Sep 5, 2019
Merged

Value Relation Widget #600

merged 26 commits into from
Sep 5, 2019

Conversation

signedav
Copy link
Member

@signedav signedav commented Jun 25, 2019

Value Relation like Relation Reference.

  • lists the referenced fields and stores the value
  • Allow Null and OrderBy
  • Multi value
  • keep index in list (on checking don't jump to start)
  • clean up model on add Feature
  • JSON implementation
  • fix that display value sometimes not displayed

Then we do the TESTS

(Dave your project is qfield_valuerelation_test)

  • tested with string on GPKG
  • tested with string on GPKG using UUIDs
  • tested with string on PG
  • tested with string on PG using UUIDs
  • tested on device
  • tested with json on GPKG (needing device)
  • tested with json on PG (needing QGIS fix = vs {})

Optional:

  • Issue with UUIDs ({} as values in hstore list)
  • Fix issue on QGIS storing stringts in {}

Looks like this

value_relation

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

src/core/featurelistmodel.h Outdated Show resolved Hide resolved
src/qml/qml.qrc Outdated Show resolved Hide resolved
@m-kuhn
Copy link
Member

m-kuhn commented Jun 26, 2019

Looking good 👍

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@m-kuhn
Copy link
Member

m-kuhn commented Jul 7, 2019

Good job so far @signedav

There is still one open issue with this, it's not working with Android 5 builds because Android 5 QGIS builds are too old.

I think before merging / releasing we need to announce this. There will be more changes like this coming at some point, it's inevitable. So if people want Android 5 support to continue, we will need to fix those builds, but we are only able to invest if this project is properly funded.

@signedav
Copy link
Member Author

There is an open Pull Request on QGIS, where utility functions would be available, we can use to convert the lists to formatted strings. Should be merged soon. Probably this week :-)

@jhonalex06
Copy link
Contributor

Hi, I have a question

i try to use the filter expression, but it didn't work, is possible implement the filter expression?

image

Thanks

@m-kuhn
Copy link
Member

m-kuhn commented Jul 26, 2019

@signedav the new SDK should include the required methods for (de)serializing pg arrays

@Emic37
Copy link

Emic37 commented Aug 28, 2019

Hi @signedav !
Have you planned to support the completer ?

@signedav
Copy link
Member Author

@Emic37 Would be nice. But not in this implementation, sorry.

@Emic37
Copy link

Emic37 commented Aug 28, 2019

@signedav Oh so disappointed! xD is it a big job to add this functionality ?

@m-kuhn m-kuhn closed this Sep 2, 2019
@m-kuhn m-kuhn reopened this Sep 2, 2019
@m-kuhn
Copy link
Member

m-kuhn commented Sep 2, 2019

@Emic37 No, it's certainly not trivial.

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@signedav
Copy link
Member Author

signedav commented Sep 2, 2019

The unsuccessful tests storing data to JSON fields in Geopackage and Postgres, should not have influences on this widget implementation. Because the part, that the widget does, works fine.

So in my opinion this is okay.

@qfield-fairy
Copy link
Collaborator

Uploaded test apks for armv7 and x86 (Android 5: armv7 and x86)

@Emic37
Copy link

Emic37 commented Sep 5, 2019

@m-kuhn Ok. Thanks for reply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants