Add topological editing toggle button (in edit mode) #939
Conversation
|
Note: for it to actually work, we'll need to update the SDK to incorporate qgis/QGIS#35647 |
|
I wasn't entirely satisfied with the lack of a visual queue to differentiate buttons (i.e. bugger dashboard button) vs toggle buttons (i.e. topological editing). I've updated things so that when topological editing is toggled on, not only is the button background going from a semi-opaque dark gray to a fully opaque one, but the icon itself goes from white to QField green: IMHO, that gives users a much clearer visual statement. That also adopts what I did with the GPS button in the non-locked state (i.e. opaque dark gray + 'location' blue icon). |
|
I see green everywhere 😉 |
| Button { | ||
| id: topologyButton | ||
| round: true | ||
| visible: stateMachine.state === "digitize" && ( dashBoard.currentLayer.geometryType() === QgsWkbTypes.PolygonGeometry || dashBoard.currentLayer.geometryType() === QgsWkbTypes.LineGeometry ) |
There was a problem hiding this comment.
As far as I understand this, it doesn't concern the selected layer but still is only visible when a layer is selected?
Shouldn't it be visible as soon as there are at least two layers with geometry line or polygon in the project - no matter if they are selected or not?
There was a problem hiding this comment.
@signedav , Matthias wants to avoid obscuring the canvas as much as possible, hence hiding when possible.
There was a problem hiding this comment.
how does it not concern the selected layer?
There was a problem hiding this comment.
First - in browsing mode - it's not visible. Then with enable digitizing mode, it's still not visible. Then I select a layer and it becomes visible. I activate it, and because it popped out by selecting the layer, I expect, that I turn it on only for this layer. But it does not concern (only) this layer. It concerns all the polygon and line layers.
If I have e.g. several point layers. And I click on one, the + appears to digitize. I expect that this + concerns only this layer. There is not an option that I can select the layer after pressing + where to add a feature. This is QGIS behavior. And so I think the activation of the topological editing should be QGIS behavior as well. Means, not appearing on selecting a specific layer.
I suggest to make it visible all the time (as soon as there are polygon or line layers) or put it somewhere else (like e.g. in the menu like the measure tool).
There was a problem hiding this comment.
I activate it, and because it popped out by selecting the layer, I expect, that I turn it on only for this layer.
I understand this assumption. But I also think it's obvious that when you change the layer and it stays the way it is it will be quite quickly visible to someone that it's not only for this layer.
For me, topological editing is an edge case. Interesting for some, a miracle for many. So it should take away users attention as little as possible.
It also will not do anything when editing a point layer, hence it doesn't make sense to show it there.
If it was for me, I'd even make it opt-in in the configuration of QField or the project to keep it hidden from the large portion of QField users that will never ever use it.
There was a problem hiding this comment.
I'm -1 to adding a setting here, that's just an extra layer of complexity that's not worth it really IMHO.
I think hiding it as much as we can, like it's done ATM, is a good balance.
Arguably, the bonus of having it show up in the narrow circumstances we have atm does provide a collateral benefit: educating users about the presence of this feature.
|
Let's merge and see how we feel about it over the course of the coming days n weeks. |
|
I think, I can endure it 😉 |
When QField has its overall navigate / edit button toggled to edit, a new topographic editing toggle button appears on the canvas:
We could possibly add another button there to toggle snapping (if that's something that wouldn't overwhelm users).