Skip to content

Commit

Permalink
feat: upgrade prettier to v3 (#7278)
Browse files Browse the repository at this point in the history
* feat: update eslint packages to stable latest versions

not v9 for now since lots of breaking changes
plugin prettier also v4 for now, v5 breaks due to

* fix: add back missed storybook lint import

* fix: remove react-app eslint rules due to incompatibility with eslint

since we are still on CRA4

* fix: add react-hooks eslint plugin since react-app plugin is removed

* feat: add eslint rules to ignore explicit anys in test code

# Conflicts:
#	.eslintrc

* fix: ALL LINT ERRORS DUE TO ANYS

* feat: add looser eslint rules for test files

* feat: upgrade prettier to v3

* fix: formatting changes

* fix: lint for shared

* fix: fix type issues on react-email templates on express server (#7279)

* fix: remove erroneous react type pkg install on root

* fix: add react-email package to root

so react-email templates has no type errors when rendering on the server

* fix: lint issues

* fix: add missing type variable

---------

Co-authored-by: Ken <ken@open.gov.sg>
  • Loading branch information
karrui and KenLSM committed May 20, 2024
1 parent 03d8a6f commit 246f905
Show file tree
Hide file tree
Showing 80 changed files with 4,551 additions and 22,086 deletions.
5 changes: 4 additions & 1 deletion frontend/.storybook/manager-head.html
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,10 @@
font-weight: 500;
font-size: 14px;
letter-spacing: -0.006em;
font-feature-settings: 'tnum' on, 'lnum' on, 'cv05' on;
font-feature-settings:
'tnum' on,
'lnum' on,
'cv05' on;

/* Secondary/700 */
color: #293044;
Expand Down
183 changes: 137 additions & 46 deletions frontend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"@types/gtag.js": "0.0.10",
"@types/jest": "^26.0.24",
"@types/node": "^16.11.12",
"@types/react": "^17.0.37",
"@types/react": "^17.0.80",
"@types/react-beautiful-dnd": "^13.1.2",
"@types/react-csv": "^1.1.2",
"@types/react-dom": "^17.0.11",
Expand All @@ -178,7 +178,7 @@
"eslint": "^8.57.0",
"eslint-config-prettier": "^8.10.0",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-prettier": "^4.2.1",
"eslint-plugin-prettier": "^5.1.3",
"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-simple-import-sort": "^12.1.0",
"eslint-plugin-storybook": "^0.5.12",
Expand All @@ -190,7 +190,7 @@
"msw": "^0.36.3",
"msw-storybook-addon": "^1.6.3",
"patch-package": "^6.4.7",
"prettier": "^2.5.1",
"prettier": "^3.2.5",
"puppeteer": "^13.0.0",
"react-refresh": "^0.14.0",
"react-scripts": "^4.0.3",
Expand Down
2 changes: 1 addition & 1 deletion frontend/public/index.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
Expand Down
Loading

0 comments on commit 246f905

Please sign in to comment.