fix: fix type issues on react-email templates on express server #7279
+5,636
−250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karrui
force-pushed
the
04-23-feat_upgrade_prettier_to_v3
branch
from
323bcc0
to
b5ef4d3
Compare
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
3f918dd
to
42e4267
Compare
karrui
force-pushed
the
04-23-feat_upgrade_prettier_to_v3
branch
from
b5ef4d3
to
ce60b15
Compare
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
42e4267
to
4bcb262
Compare
karrui
force-pushed
the
04-23-feat_upgrade_prettier_to_v3
branch
from
ce60b15
to
b608581
Compare
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
4bcb262
to
2467903
Compare
karrui
force-pushed
the
04-23-feat_upgrade_prettier_to_v3
branch
from
b608581
to
7b895f2
Compare
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
2 times, most recently
from
149f82d
to
1c85806
Compare
KenLSM
reviewed
Apr 23, 2024
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
1c85806
to
16ac46b
Compare
karrui
changed the title
karrui
changed the title
karrui
force-pushed
the
04-23-feat_upgrade_prettier_to_v3
branch
from
22d55e6
to
858b012
Compare
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
f5284ae
to
0a96443
Compare
This was referenced Apr 24, 2024
so react-email templates has no type errors when rendering on the server
karrui
force-pushed
the
04-23-feat_upgrade_prettier_to_v3
branch
from
858b012
to
05f5df4
Compare
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
0a96443
to
9f75cd7
Compare
KenLSM
merged commit a67ab30
into
04-23-feat_upgrade_prettier_to_v3
20 of 22 checks passed
KenLSM
deleted the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
KenLSM
added a commit
that referenced
this pull request
May 20, 2024
* feat: update eslint packages to stable latest versions not v9 for now since lots of breaking changes plugin prettier also v4 for now, v5 breaks due to * fix: add back missed storybook lint import * fix: remove react-app eslint rules due to incompatibility with eslint since we are still on CRA4 * fix: add react-hooks eslint plugin since react-app plugin is removed * feat: add eslint rules to ignore explicit anys in test code # Conflicts: # .eslintrc * fix: ALL LINT ERRORS DUE TO ANYS * feat: add looser eslint rules for test files * feat: upgrade prettier to v3 * fix: formatting changes * fix: lint for shared * fix: fix type issues on react-email templates on express server (#7279) * fix: remove erroneous react type pkg install on root * fix: add react-email package to root so react-email templates has no type errors when rendering on the server * fix: lint issues * fix: add missing type variable --------- Co-authored-by: Ken <ken@open.gov.sg>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fix type errors on frontend since root types are of a higher version.