fix: remove attachment integrity validation

opengovsg · May 6, 2024 · 79408a9 · 79408a9
1 parent 598c483
commit 79408a9
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 10 deletions.
diff --git a/...pp/modules/submission/multirespondent-submission/multirespondent-submission.middleware.ts b/...pp/modules/submission/multirespondent-submission/multirespondent-submission.middleware.ts
@@ -457,15 +457,16 @@ export const validateMultirespondentSubmission = async (
                     const incomingResField = req.body.responses[fieldId]
                     const prevResField = previousResponses[fieldId]
 
+                    // TODO(FRM-1724): Reenable this validation.
                     if (prevResField.fieldType === BasicField.Attachment) {
-                      prevResField.answer.content = Buffer.from(
-                        /**
-                         * JSON.parse(JSON.stringify(fooBuffer)) does not fully reconstruct the Buffer object
-                         * it gets parsed as { type: 'Buffer', data: number[] } instead of the original Buffer object
-                         */
-                        // @ts-expect-error data does not exist on Buffer
-                        prevResField.answer.content.data,
-                      )
+                      // prevResField.answer.content = Buffer.from(
+                      //   /**
+                      //    * JSON.parse(JSON.stringify(fooBuffer)) does not fully reconstruct the Buffer object
+                      //    * it gets parsed as { type: 'Buffer', data: number[] } instead of the original Buffer object
+                      //    */
+                      //   // @ts-expect-error data does not exist on Buffer
+                      //   prevResField.answer.content.data,
+                      // )
                     }
 
                     const resp = isFieldResponseV3Equal(

diff --git a/src/app/utils/response-v3.ts b/src/app/utils/response-v3.ts
@@ -1,8 +1,6 @@
-import crypto from 'crypto'
 import _ from 'lodash'
 
 import { BasicField, FieldResponseV3 } from '../../../shared/types'
-import { ParsedClearAttachmentResponseV3 } from '../../types/api'
 
 export const isFieldResponseV3Equal = (
   l: FieldResponseV3,
@@ -31,6 +29,9 @@ export const isFieldResponseV3Equal = (
     case BasicField.Children:
       return _.isEqual(l.answer, r.answer)
     case BasicField.Attachment: {
+      return true
+      // TODO(FRM-1724): Re-enable this validation
+      /**
       const lAnswer = l.answer as ParsedClearAttachmentResponseV3['answer']
       const rAnswer = r.answer as ParsedClearAttachmentResponseV3['answer']
 
@@ -47,6 +48,7 @@ export const isFieldResponseV3Equal = (
       return (
         lMd5.equals(rMd5) && l.answer.hasBeenScanned === rAnswer.hasBeenScanned
       )
+      */
     }
     case BasicField.Section:
       return true