Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove Examples frontend reliance on batch job #1021

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

mantariksh
Copy link
Contributor

@mantariksh mantariksh commented Jan 19, 2021

Problem

We are removing the batch job which counts daily submissions per form, but the frontend of the Examples page still relies on data which is computed using the batch job, namely the count of submissions and the date of last submission.

Related to #984

Solution

Remove the portions of the frontend which rely on this data.

Screenshots

Last submitted

Before

Screenshot 2021-01-19 at 4 44 46 PM

After

(missing logo due to localhost)
Screenshot 2021-01-19 at 4 45 58 PM

Submission count

Before

Screenshot 2021-01-19 at 4 46 30 PM

After

Screenshot 2021-01-19 at 4 46 46 PM

Tests

  • Go to Examples page and check that "Last Submitted" does not show in the form cards. Check that the page renders correctly in all screen sizes.
  • Open a form card and check that the number of submissions does not show. Check that the modal renders correctly in all screen sizes.

@mantariksh mantariksh merged commit aea949e into develop Jan 19, 2021
@liangyuanruo liangyuanruo deleted the feat/remove-batch-frontend branch January 26, 2021 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants