Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: release 4.54.0 #1030

Merged
merged 24 commits into from
Jan 20, 2021
Merged

build: release 4.54.0 #1030

merged 24 commits into from
Jan 20, 2021

Conversation

mantariksh
Copy link
Contributor

New

  • feat: Add cancel download attachment feature #1018

Improved

  • fix(webhook): change type from any to void, re-order imports #1023
  • feat: remove Examples frontend reliance on batch job #1021
  • feat: remove landing page reliance on batch job #1020
  • fix: incorrect mobile number placeholder #1017
  • chore(robots): disallow NLB crawler to parse beyond loading the frontend #1019

Dependency upgrades

  • fix(deps): bump @sentry/integrations from 5.29.2 to 5.30.0 #1028
  • chore(deps-dev): bump csv-parse from 4.14.2 to 4.15.0 #1027
  • build/typescript-4.1.3: TypeScript version upgrade #1029
  • chore(deps-dev): bump eslint-plugin-typesafe from 0.3.0 to 0.4.0 #1026
  • fix(deps): bump libphonenumber-js from 1.9.6 to 1.9.8 #1024
  • chore(deps-dev): bump eslint-plugin-prettier from 3.3.0 to 3.3.1 #1025
  • fix(deps): bump aws-sdk from 2.818.0 to 2.828.0 #1014
  • chore(deps-dev): bump sinon from 9.2.2 to 9.2.3 #1012
  • fix(deps): bump twilio from 3.54.1 to 3.55.0 #1010
  • chore(deps-dev): bump @types/express-serve-static-core #1011
  • fix(deps): bump @sentry/browser from 5.29.2 to 5.30.0 #1002
  • fix(deps): bump neverthrow from 3.1.4 to 3.2.0 #1008
  • chore(deps-dev): bump @types/jest from 26.0.19 to 26.0.20 #989
  • chore(deps-dev): bump @types/node from 14.14.14 to 14.14.20 #997
  • chore(deps-dev): bump husky from 4.3.6 to 4.3.7 #1006
  • chore(deps-dev): bump @types/validator from 13.1.2 to 13.1.3 #1001

liangyuanruo and others added 24 commits January 14, 2021 13:58
chore: merge 4.53.0 back to develop
Bumps [@types/validator](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/validator) from 13.1.2 to 13.1.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/validator)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [husky](https://github.com/typicode/husky) from 4.3.6 to 4.3.7.
- [Release notes](https://github.com/typicode/husky/releases)
- [Commits](typicode/husky@v4.3.6...v4.3.7)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.14 to 14.14.20.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 26.0.19 to 26.0.20.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [neverthrow](https://github.com/supermacro/neverthrow) from 3.1.4 to 3.2.0.
- [Release notes](https://github.com/supermacro/neverthrow/releases)
- [Commits](supermacro/neverthrow@3.1.4...v3.2.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 5.29.2 to 5.30.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@5.29.2...5.30.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@types/express-serve-static-core](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/express-serve-static-core) from 4.17.17 to 4.17.18.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/express-serve-static-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [twilio](https://github.com/twilio/twilio-node) from 3.54.1 to 3.55.0.
- [Release notes](https://github.com/twilio/twilio-node/releases)
- [Changelog](https://github.com/twilio/twilio-node/blob/main/CHANGES.md)
- [Commits](twilio/twilio-node@3.54.1...3.55.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…end (#1019)

There are no real URLs in bundle.js, so don't let NLB
go beyond the file lest they start to mistakenly query
for paths that don't exist
* feat: implement getFormCount

* feat: use new getFormCount in controller

* feat: remove analytics factory

* feat: remove old form count functions

* test: fix tests
* feat: remove submissions info from Examples

* docs: fix comment on form shape

* ref: delete unused view
Co-authored-by: Yuanruo Liang <yuanruo@open.gov.sg>
Bumps [sinon](https://github.com/sinonjs/sinon) from 9.2.2 to 9.2.3.
- [Release notes](https://github.com/sinonjs/sinon/releases)
- [Changelog](https://github.com/sinonjs/sinon/blob/master/CHANGELOG.md)
- [Commits](sinonjs/sinon@v9.2.2...v9.2.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.818.0 to 2.828.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.818.0...v2.828.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/prettier/eslint-plugin-prettier/releases)
- [Changelog](https://github.com/prettier/eslint-plugin-prettier/blob/master/CHANGELOG.md)
- [Commits](prettier/eslint-plugin-prettier@v3.3.0...v3.3.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.6 to 1.9.8.
- [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/commits/master)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [eslint-plugin-typesafe](https://github.com/liangyuanruo/eslint-plugin-typesafe) from 0.3.0 to 0.4.0.
- [Release notes](https://github.com/liangyuanruo/eslint-plugin-typesafe/releases)
- [Commits](https://github.com/liangyuanruo/eslint-plugin-typesafe/commits)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(config): promise void

* build(typescript): bump version to 4.1.3

Co-authored-by: Yuanruo Liang <yuanruo@open.gov.sg>
Bumps [csv-parse](https://github.com/wdavidw/node-csv-parse) from 4.14.2 to 4.15.0.
- [Release notes](https://github.com/wdavidw/node-csv-parse/releases)
- [Changelog](https://github.com/adaltas/node-csv-parse/blob/master/CHANGELOG.md)
- [Commits](adaltas/node-csv-parse@v4.14.2...v4.15.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 5.29.2 to 5.30.0.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@5.29.2...5.30.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
Copy link
Contributor Author

mantariksh commented Jan 20, 2021

Tests

Cancel attachment download

  • Make sure downloads are properly canceled, and that future downloads from the same page (both CSV and attachments) are not affected.

@mantariksh
Copy link
Contributor Author

mantariksh commented Jan 20, 2021

Tests

Intranet IE11 tests for this week

Batch job dependencies

  • Go to Examples page and check that "Last Submitted" does not show in the form cards. Check that the page renders correctly in all screen sizes.
  • Open a form card and check that the number of submissions does not show. Check that the modal renders correctly in all screen sizes.

Mobile number placeholder bug

  • Create form with home number field followed by mobile number field
  • Publish form and open in public view. Check that placeholder for both home number and mobile number field are correct
  • Test that form can be submitted

@mantariksh
Copy link
Contributor Author

mantariksh commented Jan 20, 2021

Tests

IE11 intranet general run-through

  • Create email mode form with all fields. Activate and submit form. Check that you can receive responses in your GSIB inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments for individual fields can be downloaded from Data tab in storage mode.
  • Attachment ZIP for submission can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

@mantariksh mantariksh merged commit b08b9a9 into release Jan 20, 2021
@karrui karrui deleted the release-4.54.0 branch April 21, 2021 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants