feat: remove passThroughFeedback #1298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @jia1 , I think there should be a corresponding frontend change first to migrate off the backend API? |
karrui
requested changes
Mar 17, 2021
src/public/modules/forms/base/components/feedback-form.client.component.js
Outdated
Show resolved
Hide resolved
|
Thank you Yuan Ruo and Kar Rui for your feedback. |
karrui
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
lgtm, but this change is not backwards compatible meaning old clients who preview feedback submission will see a failure instead.
For statistics, we get ~10 of such passthrough requests everyday. I'd reckon we can do this in a backwards incompatible way and just merge this PR in, instead of keeping the old endpoint in for a couple weeks.
Thoughts @liangyuanruo?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #786